Add email subscription field with popup in footer #2797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for howto-fix-macos-audio-selection ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
92
to
112
| onSuccess: () => { | ||
| setPopoverOpen(false); | ||
| setEmail(""); | ||
| setSubscriptions({ | ||
| releaseNotesStable: false, | ||
| releaseNotesBeta: false, | ||
| newsletter: false, | ||
| }); | ||
| }, |
Contributor
There was a problem hiding this comment.
The form field is not being reset after successful subscription. When setEmail("") is called, it only clears the email state variable, but the form's internal state (field.state.value) is not reset. After a successful subscription, the email input will still display the previously entered email address.
To fix this, reset the form state:
onSuccess: () => {
setPopoverOpen(false);
form.reset();
setEmail("");
setSubscriptions({
releaseNotesStable: false,
releaseNotesBeta: false,
newsletter: false,
});
},
Suggested change
| onSuccess: () => { | |
| setPopoverOpen(false); | |
| setEmail(""); | |
| setSubscriptions({ | |
| releaseNotesStable: false, | |
| releaseNotesBeta: false, | |
| newsletter: false, | |
| }); | |
| }, | |
| onSuccess: () => { | |
| setPopoverOpen(false); | |
| form.reset(); | |
| setEmail(""); | |
| setSubscriptions({ | |
| releaseNotesStable: false, | |
| releaseNotesBeta: false, | |
| newsletter: false, | |
| }); | |
| }, |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
devin-ai-integration
bot
force-pushed
the
devin/1767528126-footer-email-subscription
branch
from
4c175db to
3f8ffa3
Compare
ComputelessComputer
force-pushed
the
devin/1767528126-footer-email-subscription
branch
2 times, most recently
from
05ad1b9 to
15e1de4
Compare
ComputelessComputer
force-pushed
the
devin/1767528126-footer-email-subscription
branch
from
15e1de4 to
06cef85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add email subscription field with popup in footer
Summary
Adds an email subscription input to the website footer's brand section. When a user enters their email and submits, a popover expands showing checkboxes for subscription preferences:
The subscription data is sent to Loops with the new preference fields (
releaseNotesStable,releaseNotesBeta,newsletter).Updates since last revision
Review & Testing Checklist for Human
releaseNotesStable,releaseNotesBeta, andnewsletterfields exist in your Loops contact schema. If not configured, these values may be silently ignored.max-w-[220px]which may need adjustment on smaller screensRecommended test plan:
Notes
addContactfunction from@/functions/loopswith extended schemaCheckbox,Popover) from@hypr/uiLink to Devin run: https://app.devin.ai/sessions/f88d8a8bafa04089ae20a4897504f1e2
Requested by: [email protected] (@ComputelessComputer)