feat(web): redirect authenticated users via deeplink when opening login from desktop app #2929
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in from desktop app When a user opens the login page from the desktop app but already has an active auth session, redirect them directly back to the app via deeplink instead of showing the login page. Co-Authored-By: [email protected] <[email protected]>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for howto-fix-macos-audio-selection canceled.
|
ComputelessComputer
deleted the
devin/1767945692-auth-session-redirect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(web): redirect authenticated users via deeplink when opening login from desktop app
Summary
When a user opens the login page from the desktop app but already has an active auth session in the browser, they are now redirected directly back to the app via deeplink instead of showing the login page.
The change adds a
beforeLoadhook to the/authroute that:flow=desktop, redirects to/callback/authwith the session tokens (which then triggers the deeplink back to the app)flow=web, redirects to the specified redirect URL or/app/accountReview & Testing Checklist for Human
/authwhen not logged in should show login page)Notes
_view/app/route.tsxfor session checkingLink to Devin run: https://app.devin.ai/sessions/78993246b5074d7ab14b620fbb11fd71
Requested by: @ComputelessComputer