Conversation
…th nango dep Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for hyprnote canceled.
|
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scaffold
crates/api-integrationwith nango dependencySummary
Scaffolds a new
crates/api-integrationcrate following the same structure ascrates/api-subscription, but usinghypr-nango(Nango client) as the core dependency instead of Stripe.Modules added:
config.rs—IntegrationConfigwithnango_api_base,nango_api_key, optional authenv.rs—Envstruct for deserializing environment configerror.rs—IntegrationErrorenum withFromimpls for nango/auth errors,IntoResponsestate.rs—AppStateholding config +NangoClientroutes/connect.rs—POST /connect-sessionendpoint (creates a Nango connect session)routes/mod.rs— router + OpenAPI doc generationRegistered as
hypr-api-integrationin workspaceCargo.toml.Review & Testing Checklist for Human
AppState::newreturningResultinstead ofSelfwork for your wiring code?)allowed_integrations: vec![]is hardcoded empty inconnect.rs:L53— confirm whether this should be parameterized or populated from configreqwest,tokio,serde_jsonare declared as deps but unused in current source — decide if you want to keep them for future use or trimNotes
cargo check -p api-integrationdprint fmtnangocrate (post-PR refactor(nango): split into modules and add missing proxy methods #3702), which changedNangoClientBuilder::build()to returnResultLink to Devin run · Requested by @yujonglee