Skip to content

add default retry policy for nango proxy calls#3704

Merged
yujonglee merged 1 commit intomainfrom
devin/1770469180-nango-proxy-retry-defaults
Feb 7, 2026
Merged

add default retry policy for nango proxy calls#3704
yujonglee merged 1 commit intomainfrom
devin/1770469180-nango-proxy-retry-defaults

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Feb 7, 2026

Summary

Sets sensible default retry configuration on NangoClient::for_connection() so all proxy requests automatically leverage Nango's server-side retry mechanism. This addresses Nango's rate limit guidance by retrying on 429 (and common server errors) up to 3 times via Nango's built-in Retries/Retry-On proxy headers — no new dependencies needed.

Currently for_connection() has no production callers (only test usage), so this ensures the right defaults are in place before proxy calls are wired up.

Review & Testing Checklist for Human

  • Confirm the retry status code set (429, 500, 502, 503, 504) is appropriate — particularly whether retrying on 500 is desired for your proxy use cases
  • Note that callers can still override via .retries(N) / .retry_on(...) if different behavior is needed per call site

Notes


Open with Devin

Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@netlify
Copy link

netlify bot commented Feb 7, 2026

Deploy Preview for hyprnote-storybook canceled.

Name Link
🔨 Latest commit 6e2f9e7
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/698738cf116c340008dffb4c

@netlify
Copy link

netlify bot commented Feb 7, 2026

Deploy Preview for hyprnote canceled.

Name Link
🔨 Latest commit 6e2f9e7
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/698738cf95b0290008c1727c

Copy link
Contributor Author

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@yujonglee yujonglee merged commit 0ff839f into main Feb 7, 2026
16 of 17 checks passed
@yujonglee yujonglee deleted the devin/1770469180-nango-proxy-retry-defaults branch February 7, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant