add default retry policy for nango proxy calls#3704
Merged
Conversation
Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for hyprnote canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sets sensible default retry configuration on
NangoClient::for_connection()so all proxy requests automatically leverage Nango's server-side retry mechanism. This addresses Nango's rate limit guidance by retrying on 429 (and common server errors) up to 3 times via Nango's built-inRetries/Retry-Onproxy headers — no new dependencies needed.Currently
for_connection()has no production callers (only test usage), so this ensures the right defaults are in place before proxy calls are wired up.Review & Testing Checklist for Human
429, 500, 502, 503, 504) is appropriate — particularly whether retrying on500is desired for your proxy use cases.retries(N)/.retry_on(...)if different behavior is needed per call siteNotes