Notify Slack only on review submission and remove Merge button #3872
+9
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only send Slack notifications when an article is submitted for review (ready_for_review == true) and remove the "Merge" button from the Slack message. This avoids noisy notifications on every save/edit and prevents offering a merge action from Slack — merging should be done via the GitHub UI. Changes: - Added review-status check to the Notify Slack step condition so messages are only sent on submission for review. - Replaced dynamic message text with a fixed "Article submitted for review" message and adjusted attachment color to the review color. - Removed the "Merge" button from the Slack message attachments. - Updated admin README to reflect that no notification is sent on save and to document the new review notification behavior and removed merge action.
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only send Slack notifications when an article is submitted for review
(ready_for_review == true) and remove the "Merge" button from the Slack
message. This avoids noisy notifications on every save/edit and prevents
offering a merge action from Slack — merging should be done via the
GitHub UI.
Changes: