Remove older ruby tests #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@etagwerker could you please review the PR? #121 should be closed in favor of this PR. |
Ruby 2.0 does not support Rainbow 3
JuanVqz
force-pushed
the
fixes/remove-older-ruby-tests
branch
from
2b640d3 to
94e431a
Compare
etagwerker
approved these changes
Sep 24, 2024
|
@JuanVqz just curious, why should we support not sure what it is but removing support for older rubies means we can't use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ruby 2.0.0, 2.1, 2.2 does not support Rainbow 3, so, we are removing support for older Ruby versions.
Motivation and Context
Moving away of the Colorize dependency gem because it uses GPL 2.0 license.
#120
How Has This Been Tested?
Running the test suite
Screenshots:
I will abide by the code of conduct