Skip to content

Add Ruby 3.4 support #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Add Ruby 3.4 support #133

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
816e5b6
Add Ruby 3.4 support
JuanVqz Feb 4, 2025
626f4eb
Update next_rails.gemspec
JuanVqz Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ["3.3", "3.2", "3.1", "3.0", "2.7", "2.6"]
ruby-version: ["3.4", "3.3", "3.2", "3.1", "3.0", "2.7", "2.6"]

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# main [(unreleased)](https://github.com/fastruby/next_rails/compare/v1.4.2...main)

- [Add Ruby 3.4 support](https://github.com/fastruby/next_rails/pull/133)

* Your changes/patches go here.

# v1.4.2 / 2024-10-25 [(commits)](https://github.com/fastruby/next_rails/compare/v1.4.1...v1.4.2)
Expand Down
4 changes: 2 additions & 2 deletions next_rails.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Gem::Specification.new do |spec|
spec.homepage = "https://github.com/fastruby/next_rails"
spec.license = "MIT"

spec.required_ruby_version = ">= 2.0"
spec.required_ruby_version = ">= 2.0", "< 3.5"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would be ideal to block supported Ruby versions to make sure users can rely on it, happy to remove it if you don't find it valuable tho


spec.files = `git ls-files -z`.split("\x0").reject do |f|
f.match(%r{^(test|spec|features)/})
Expand All @@ -30,5 +30,5 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "timecop", "~> 0.9.1"
spec.add_development_dependency "byebug"
spec.add_development_dependency "rexml", "3.3.8" # limited on purpose, new versions don't work with old rubies
spec.add_development_dependency "webmock", "3.16.2" # limited on purpose, new versions don't work with old rubies
spec.add_development_dependency "webmock", "3.20.0"
end