BUG-149: Fix compatibilities performance bug #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FionaDL
reviewed
Apr 10, 2025
Use fetcher instead of new when we use Gem::SpecFetcher Fixes: fastruby#149
fbuys
force-pushed
the
bug/compatibilities
branch
from
f9ff1ed to
f1df7f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use fetcher instead of new when we use Gem::SpecFetcher
Fixes: #149
Description
Use fetcher instead of new when we use Gem::SpecFetcher
Fixes: #149
Motivation and Context
How Has This Been Tested?
Using
timebefore and after:42.34s user 1.83s system 97% cpu 45.095 total5.68s user 0.61s system 72% cpu 8.728 totalUsing automated tests.
Screenshots:
Using stack prof:
I will abide by the code of conduct