Skip to content

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Apr 3, 2025

Caution

Needs #32 to be merged first.

  • Add an entry to CHANGELOG.md that links to this PR under the "main (unreleased)" heading. Not done since affects only tests.

Closes #27

TERM: xterm
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
run: |
bundle install --jobs 4 --retry 3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed, setup-ruby handles this.

strategy:
matrix:
ruby-version: ["2.5", "2.6", "2.7", "3.0"]
ruby-version: ["3.2", "3.3", "3.4"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andyw8 Considering the type of projects we encounter at work, I'm not interested in dropping support for ancient rubies. There are still a ton of companies out there that still use rubies < 3.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see, let me update.

@andyw8 andyw8 force-pushed the andyw8/update-ci branch from 7906470 to 5fd4b30 Compare April 4, 2025 02:26
Copy link
Member

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andyw8 Looks good, thanks!

@etagwerker etagwerker merged commit 805b022 into fastruby:main May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Ruby 3.1 to 3.4 to the test suite

2 participants