Skip to content

Match text and JSON output #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 27, 2025
Merged

Match text and JSON output #40

merged 11 commits into from
May 27, 2025

Conversation

hmdros
Copy link
Contributor

@hmdros hmdros commented May 15, 2025 •
edited
Loading

Closes #39

  • Add an entry to CHANGELOG.md that links to this PR under the "main (unreleased)" heading.

Description:

Add "Code" and "Tests" total count from bottom of report to JSON output

Also pushed changes to console-output.txt to fix the tests

I will abide by the code of conduct.

@hmdros hmdros force-pushed the match-json-output branch from ce222b0 to cf66842 Compare May 15, 2025 17:34
@codecov Codecov
Copy link

codecov bot commented May 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.86%. Comparing base (3aa647a) to head (8f3974d).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
lib/rails_stats/json_formatter.rb 91.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   82.57%   82.86%   +0.29%     
==========================================
  Files          19       19              
  Lines         677      683       +6     
==========================================
+ Hits          559      566       +7     
+ Misses        118      117       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

etagwerker
etagwerker approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hmdros Looks good! Could you please add an entry to the CHANGELOG file?

@hmdros
add @code_total and @tests_total to output in json
2ae8cf5 
adjust labels

adjust order

fix console output to fix tests

adjust json tests

fix tests from console output

Add change to CHANGELOG.md
@hmdros hmdros force-pushed the match-json-output branch from f5c475f to 2ae8cf5 Compare May 16, 2025 11:19
@hmdros
Copy link
Contributor Author

hmdros commented May 23, 2025

@hmdros Looks good! Could you please add an entry to the CHANGELOG file?

Hey @etagwerker I added the CHANGELOG entry.
Later I noticed the gem were missing a call to Bundler::Stats::CLI.start(["-f", "json"]) to match the initial block from the console output and added it now. Do you mind reviewing it again?

@hmdros hmdros force-pushed the match-json-output branch 9 times, most recently from adad479 to db2f355 Compare May 26, 2025 19:43
@hmdros hmdros force-pushed the match-json-output branch from db2f355 to f95fe1b Compare May 26, 2025 19:44
@hmdros hmdros force-pushed the match-json-output branch from 4b219d5 to 1dcfe77 Compare May 27, 2025 13:36
@hmdros hmdros force-pushed the match-json-output branch from cdacb88 to bb4a58f Compare May 27, 2025 13:53
@etagwerker etagwerker merged commit 8f2e5b7 into main May 27, 2025
4 checks passed
@etagwerker etagwerker deleted the match-json-output branch May 27, 2025 14:17
fbuys
fbuys reviewed May 27, 2025
View reviewed changes
.github/workflows/test.yml
- name: Install Bundler
run: |
if [[ "${{ matrix.ruby-version }}" == "2.6" || "${{ matrix.ruby-version }}" == "2.7" ]]; then
if [[ "${{ matrix.ruby-version }}" == "2.5" ]]; then
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.5 CI still fails, but it looks like it is unrelated.
https://github.com/fastruby/rails_stats/actions/runs/15276802903/job/42965637852?pr=40

README.md
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of changes in this file, is there anything in particular you would like to call out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did reduce the number of examples to 1. Also the output is a little bigger now, since we bring more information

CHANGELOG.md

*
* [BUGFIX: Fix JSON output missing Code and Tests total count](https://github.com/fastruby/rails_stats/pull/40)
* Update README examples
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Update README examples
* [CHORE: Update README examples](https://github.com/fastruby/rails_stats/pull/40)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fbuys fbuys fbuys left review comments

@etagwerker etagwerker etagwerker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Match text and JSON output

3 participants

@hmdros @etagwerker @fbuys