Modify bandwidth-test to use command-line tool execution#20
Merged
Conversation
Co-Authored-By: fatedier <fatedier@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…tory Co-Authored-By: fatedier <fatedier@gmail.com>
…Getwd()/bin Co-Authored-By: fatedier <fatedier@gmail.com>
Co-Authored-By: fatedier <fatedier@gmail.com>
Co-Authored-By: fatedier <fatedier@gmail.com>
Co-Authored-By: fatedier <fatedier@gmail.com>
Co-Authored-By: fatedier <fatedier@gmail.com>
Co-Authored-By: fatedier <fatedier@gmail.com>
…timing logic Co-Authored-By: fatedier <fatedier@gmail.com>
Co-Authored-By: fatedier <fatedier@gmail.com>
Co-Authored-By: fatedier <fatedier@gmail.com>
fatedier
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify bandwidth-test to use command-line tool execution
This PR modifies the bandwidth-test tool to use external process execution instead of embedded service creation. The changes:
Processstruct to manage external command executionrunBandwidthTestto launch ffts/fftw/fft as separate processesThese changes decouple the bandwidth-test from the core code, simulating direct user operations by launching independent processes.
Link to Devin run: https://app.devin.ai/sessions/11f53f3220ba460ca53ff68829597d60
Requested by: fatedier