Skip to content

Conversation

@leouieda
Copy link
Member

@leouieda leouieda commented Apr 6, 2020

New minor release with new features and bug fixes. No breaking changes
or deprecations.

Reminders:

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and the base __init__.py file for the package.
  • Write detailed docstrings for all functions/classes/methods. It often helps to design better code if you write the docstrings first.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.
  • Add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.

New minor release with new features and bug fixes. No breaking changes
or deprecations.
@leouieda
Copy link
Member Author

leouieda commented Apr 6, 2020

@jessepisel @santisoler I'll make this release to get the bug fixes and new features. I still have to think about #245 so it might take a while. Could either of you give the changelog a quick proof read?

*Released on: 2020/04/06*

.. image:: https://zenodo.org/badge/DOI/10.5281/zenodo.3739449.svg
:target: https://doi.org/10.5281/zenodo.3739449
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this link and the page returned Error: DOI Not Found. I am guessing it takes a little while for doi.org to populate with the latest release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no, that will only go live once we publish the release. We need the tagged version before we can actually publish on Zenodo so we have to reserve the DOI, release, and then upload the code archive.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes sense. Good to know!

Copy link
Contributor

@jessepisel jessepisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only a couple of things that I noticed. Otherwise it should be good to release! Nice work on the release @santisoler and @leouieda there are a lot of fun new functions in here!

Co-Authored-By: Jesse Pisel <jessepisel@users.noreply.github.com>
@leouieda
Copy link
Member Author

leouieda commented Apr 6, 2020

👍 thanks, Jesse! I'll merge and release as soon as the CIs pass.

This was a fun release to work on :) Found a lot of these from actually using Verde on the final year project of some undergraduate students.

@leouieda leouieda merged commit 116e8a1 into master Apr 6, 2020
@leouieda leouieda deleted the changelog branch April 6, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants