Merged
Conversation
* replace echo with printf * ensure diagnostic messages go to stderr * ensure unique exit code for each lint failure
After a GitHub runner release of the ubuntu:22.04 in February, the vimlint call started failing without providing any output that described the vimlint failure. This seems to be for two reasons that work in concert. First, vimlint was exiting non-zero and causing script/lint to exit without reporting vimlint's output, because scripts/lint had errexit set, causing it exit immediately. This was likely either a long standing problem that was not detected in fatih#3666 or it's a new development that arose with the GitHub ubuntu:22.04 runner release that was made recently. Second, the call depth being analysed by vimlint exceeded maxfuncdepth, so set it to a higher value by leveraging VIMLINT_VIM to set maxfuncdepth to 200 to avoid vimlint exiting non-zero due to that. VIMLINT_VIM seems to be an undocumented feature that was intended to client use. It's difficult to if the failure due to the maxfuncdepth violation is a new development or not, but it seems likely.
Use grep -E with vimlint instead of egrep, because egrep is deprecated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/lint: small refactors
scripts/lint: avoid unexpected vimlint failure
After a GitHub runner release of the ubuntu:22.04 in February, the
vimlint call started failing without providing any output that described
the vimlint failure. This seems to be for two reasons that work
in concert.
First, vimlint was exiting non-zero and causing script/lint
to exit without reporting vimlint's output, because scripts/lint had
errexit set, causing it exit immediately. This was likely either a long
standing problem that was not detected in #3666 or it's a new
development that arose with the GitHub ubuntu:22.04 runner release that
was made recently.
Second, the call depth being analysed by vimlint exceeded maxfuncdepth,
so set it to a higher value by leveraging VIMLINT_VIM to set
maxfuncdepth to 200 to avoid vimlint exiting non-zero due to that.
VIMLINT_VIM seems to be an undocumented feature that was intended to
client use. It's difficult to if the failure due to the maxfuncdepth
violation is a new development or not, but it seems likely.
scripts/lint: use grep -E with vimlint
Use grep -E with vimlint instead of egrep, because egrep is deprecated.