Skip to content

Refactor message analysis logic for improved performance. Resolves #12 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 11 additions & 17 deletions src/Application/src/RazorPagesTestSample/Pages/Index.cshtml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -68,26 +68,20 @@ public async Task<IActionResult> OnPostAnalyzeMessagesAsync()

if (Messages.Count == 0)
{
MessageAnalysisResult = "There are no messages to analyze.";
MessageAnalysisResult = "There are no messages to analyze.";
}
else
{
// Speed loop. Lower this number once every quarter so we
// get our performance improvement quarterly bonus.
for (int i = 0; i < 3000; i++)
{
Thread.Sleep(1);
}

var wordCount = 0;

foreach (var message in Messages)
{
wordCount += message.Text.Split(' ').Length;
}

var avgWordCount = Decimal.Divide(wordCount, Messages.Count);
MessageAnalysisResult = $"The average message length is {avgWordCount:0.##} words.";
// Removed the unnecessary delay loop for performance improvement
var wordCount = 0;

foreach (var message in Messages)
{
wordCount += message.Text.Split(' ', StringSplitOptions.RemoveEmptyEntries).Length;
}

var avgWordCount = (decimal)wordCount / Messages.Count;
MessageAnalysisResult = $"The average message length is {avgWordCount:0.##} words.";
}

return RedirectToPage();
Expand Down
Loading