2.1

[moonglum]

This PR does not merge into the main branch, but into a branch based on the 2.0.0 release. My idea is to release a non-breaking release of faucet-pipeline-core. It contains:

• the three non-breaking changes before the breaking changes
• adjustments to the Node support matrix to remove EOL Node versions
• Add support for the new faucet-pipeline-assets

The last one is the main reason for a 2.1.0 release. I released faucet-pipeline-assets today. It is the 2.2 branch of static with the following changes:

• Renamed to faucet-pipeline-assets - using the assets key instead of the keyword static
• Removed the option to use faucet-pipeline-core 3 so people do not upgrade yet
• Remove the TypeScript stuff as it causes trouble, and this should go out soon, with no trouble.
• It is on Codeberg, not GitHub.

The plugin already works in an ESM project:

import * as assetPlugin from "faucet-pipeline-assets";

export const assets = [{
    source: "./src",
    target: "./dist/"
}];

export const plugins = [ assetPlugin ];

Adding it to core removes the need for the first and last line.

[moonglum]

We could also add faucet-pipeline-css to the default plugins while we're at it 🤔

[FND]

We could also add faucet-pipeline-css to the default plugins

In a perfect world, I'd revisit the decision to have default plugins in the first place: As evidenced by this entire process, things seem overly entangled. Having said that, it might still be the right choice; I haven't really thought it through...

So I'm a bit hesitant, but given where we stand now, your suggestion seems reasonable.

Of course that also means we have to use a monorepo and, while we're at it, have we considered Kubernetes?

[FND]

Good job, thank you!

[FND]

Suggested change

	- 20.x
	- 22.x
	- 24.x
	- 20.x
	- 24.x
	- latest

Surely YAML can import such definitions from npm so we don't have to keep doing this everywhere? 😉

[FND]

Suggested change

	notable changes for end users:
	* added support for faucet-pipeline-assets
	notable changes for end users:
	* added support for faucet-pipeline-assets

for consistency 🙂

Oh, also, the date above is no longer correct...

[moonglum]

I was too optimistic 😄

[FND]

Aside: GitHub only offers the "Rebase and merge" button, despite the history being linear for 2.x AFAICT - that seems like an unpleasant bug (because experience suggests it will actually rewrite history instead of fast-forwarding)?

[moonglum]

Version 2.1 is now released. The following faucet config will work now:

export const assets = [{
		source: "./src/foo.txt",
		target: "./dist/foo.txt"
}];

Now, I will need to update the documentation. I also noticed that the current version of faucet-pipeline-css does not work. So expect a PR on that as well 😂 Man, dusting off old projects sure releases a ton of dust.

Aside: GitHub only offers the "Rebase and merge" button, despite the history being linear for 2.x AFAICT - that seems like an unpleasant bug (because experience suggests it will actually rewrite history instead of fast-forwarding)?

I'm pretty sure we have used rebase and merge for ages. But I don't get what you are saying: The history is linear in this case (even though it is rewritten).