Skip to content

2.1 #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 26, 2025
Merged

2.1 #163

merged 5 commits into from
Oct 26, 2025

Conversation

@moonglum
Copy link
Member

@moonglum moonglum commented Oct 23, 2025 •
edited
Loading

This PR does not merge into the main branch, but into a branch based on the 2.0.0 release. My idea is to release a non-breaking release of faucet-pipeline-core. It contains:

  • the three non-breaking changes before the breaking changes
  • adjustments to the Node support matrix to remove EOL Node versions
  • Add support for the new faucet-pipeline-assets

The last one is the main reason for a 2.1.0 release. I released faucet-pipeline-assets today. It is the 2.2 branch of static with the following changes:

  • Renamed to faucet-pipeline-assets - using the assets key instead of the keyword static
  • Removed the option to use faucet-pipeline-core 3 so people do not upgrade yet
  • Remove the TypeScript stuff as it causes trouble, and this should go out soon, with no trouble.
  • It is on Codeberg, not GitHub.

The plugin already works in an ESM project:

import * as assetPlugin from "faucet-pipeline-assets";

export const assets = [{
    source: "./src",
    target: "./dist/"
}];

export const plugins = [ assetPlugin ];

Adding it to core removes the need for the first and last line.

FND added 3 commits October 23, 2025 22:23
@FND @moonglum
replaced promisify with native alternatives
a709c62 
in the process, also got rid of obsolete workarounds for legacy versions
@FND @moonglum
switched to proper Set and Map instances
70d177f 
replacing poor man's versions
@FND @moonglum
tweaked syntax for functions without arguments
81e6a9c 
shorthand does more harm than good
@moonglum moonglum requested a review from FND October 23, 2025 21:03
@moonglum
Copy link
Member Author

moonglum commented Oct 26, 2025

We could also add faucet-pipeline-css to the default plugins while we're at it 🤔

@FND
Copy link
Contributor

FND commented Oct 26, 2025 •
edited
Loading

We could also add faucet-pipeline-css to the default plugins

In a perfect world, I'd revisit the decision to have default plugins in the first place: As evidenced by this entire process, things seem overly entangled. Having said that, it might still be the right choice; I haven't really thought it through...

So I'm a bit hesitant, but given where we stand now, your suggestion seems reasonable.

Of course that also means we have to use a monorepo and, while we're at it, have we considered Kubernetes?

FND
FND approved these changes Oct 26, 2025
View reviewed changes
Copy link
Contributor

@FND FND left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thank you!

.github/workflows/tests.yaml
Comment on lines 10 to 11
- 20.x
- 22.x
- 24.x
Copy link
Contributor

@FND FND Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 20.x
- 22.x
- 24.x
- 20.x
- 24.x
- latest

Surely YAML can import such definitions from npm so we don't have to keep doing this everywhere? 😉

CHANGELOG.md Outdated
Comment on lines 10 to 11
notable changes for end users:
* added support for faucet-pipeline-assets
Copy link
Contributor

@FND FND Oct 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
notable changes for end users:
* added support for faucet-pipeline-assets
notable changes for end users:
* added support for faucet-pipeline-assets

for consistency 🙂

Oh, also, the date above is no longer correct...

Copy link
Member Author

@moonglum moonglum Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was too optimistic 😄

@FND
Copy link
Contributor

FND commented Oct 26, 2025 •
edited
Loading

Aside: GitHub only offers the "Rebase and merge" button, despite the history being linear for 2.x AFAICT - that seems like an unpleasant bug (because experience suggests it will actually rewrite history instead of fast-forwarding)?

@moonglum moonglum merged commit 89cc443 into 2.x Oct 26, 2025
3 checks passed
@moonglum moonglum deleted the 2.1 branch October 26, 2025 18:14
@moonglum
Copy link
Member Author

moonglum commented Oct 26, 2025

Version 2.1 is now released. The following faucet config will work now:

export const assets = [{
		source: "./src/foo.txt",
		target: "./dist/foo.txt"
}];

Now, I will need to update the documentation. I also noticed that the current version of faucet-pipeline-css does not work. So expect a PR on that as well 😂 Man, dusting off old projects sure releases a ton of dust.

Aside: GitHub only offers the "Rebase and merge" button, despite the history being linear for 2.x AFAICT - that seems like an unpleasant bug (because experience suggests it will actually rewrite history instead of fast-forwarding)?

I'm pretty sure we have used rebase and merge for ages. But I don't get what you are saying: The history is linear in this case (even though it is rewritten).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FND FND FND approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@moonglum @FND