Skip to content

removed support for faucet-pipeline-static and FileFinder #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
+2 −184
Merged

removed support for faucet-pipeline-static and FileFinder #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/plugins.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ let DEFAULTS = [{
key: "sass",
bucket: "styles",
plugin: "faucet-pipeline-sass"
}, {
key: "static",
bucket: "static",
plugin: "faucet-pipeline-static"
}, {
key: "images",
bucket: "static",
Expand Down
59 changes: 0 additions & 59 deletions lib/util/files/finder.js
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions ...e_modules/faucet-pipeline-static/index.js → ...e_modules/faucet-pipeline-assets/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions test/test_plugins.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@ let DEFAULTS = {
bucket: "styles",
plugin: "faucet-pipeline-sass"
},
static: {
bucket: "static",
plugin: "faucet-pipeline-static"
},
images: {
bucket: "static",
plugin: "faucet-pipeline-images"
Expand Down
115 changes: 0 additions & 115 deletions test/test_util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,10 @@
"use strict";

let { generateFingerprint } = require("../lib/util");
let { FileFinder } = require("../lib/util/files/finder");
let { describe, it } = require("node:test");
let path = require("path");
let assert = require("assert");

let assertSame = assert.strictEqual;
let assertDeep = assert.deepStrictEqual;

let FIXTURES_PATH = path.resolve(__dirname, "fixtures");

describe("fingerprinting", () => {
it("generates a content-dependent hash", () => {
Expand All @@ -25,113 +20,3 @@ describe("fingerprinting", () => {
assertSame(fingerprint, "/path/to/baz-8047cfaac755e5c7f77af066123980a5");
});
});

describe("FileFinder", () => {
it("finds all files within a folder", () => {
let fileFinder = new FileFinder(FIXTURES_PATH);

return fileFinder.all().
then(allFiles => {
assertDeep(allFiles, [
"dud.js",
"dummy/.keep",
"dummy/index.js",
"dummy/src.js",
"node_modules/dummy/images/.keep",
"node_modules/dummy/index.js",
"node_modules/dummy/pkg.js",
"node_modules/faucet-pipeline-dummy/index.js",
"node_modules/faucet-pipeline-invalid-a/index.js",
"node_modules/faucet-pipeline-invalid-b/index.js",
"node_modules/faucet-pipeline-invalid-c/index.js",
"node_modules/faucet-pipeline-js/index.js",
"node_modules/faucet-pipeline-sass/index.js",
"node_modules/faucet-pipeline-static/index.js"
]);
});
});

it("finds all files within a folder without dotfiles", () => {
let fileFinder = new FileFinder(FIXTURES_PATH, { skipDotfiles: true });

return fileFinder.all().
then(allFiles => {
assertDeep(allFiles, [
"dud.js",
"dummy/index.js",
"dummy/src.js",
"node_modules/dummy/index.js",
"node_modules/dummy/pkg.js",
"node_modules/faucet-pipeline-dummy/index.js",
"node_modules/faucet-pipeline-invalid-a/index.js",
"node_modules/faucet-pipeline-invalid-b/index.js",
"node_modules/faucet-pipeline-invalid-c/index.js",
"node_modules/faucet-pipeline-js/index.js",
"node_modules/faucet-pipeline-sass/index.js",
"node_modules/faucet-pipeline-static/index.js"
]);
});
});

it("finds all files within a folder with a filter", () => {
let fileFinder = new FileFinder(FIXTURES_PATH, {
filter: filename => path.basename(filename) === "index.js"
});

return fileFinder.all().
then(allFiles => {
assertDeep(allFiles, [
"dummy/index.js",
"node_modules/dummy/index.js",
"node_modules/faucet-pipeline-dummy/index.js",
"node_modules/faucet-pipeline-invalid-a/index.js",
"node_modules/faucet-pipeline-invalid-b/index.js",
"node_modules/faucet-pipeline-invalid-c/index.js",
"node_modules/faucet-pipeline-js/index.js",
"node_modules/faucet-pipeline-sass/index.js",
"node_modules/faucet-pipeline-static/index.js"
]);
});
});

it("matches given files", () => {
let fileFinder = new FileFinder(FIXTURES_PATH);
let foo = [
path.resolve(FIXTURES_PATH, "dummy/index.js"),
path.resolve(FIXTURES_PATH, "something.js"),
path.resolve(FIXTURES_PATH, "../other/something.js")
];

fileFinder.match(foo).
then(allFiles => {
assertDeep(allFiles, ["dummy/index.js", "something.js"]);
});
});

it("matches given files without dotfiles", () => {
let fileFinder = new FileFinder(FIXTURES_PATH, { skipDotfiles: true });
let foo = [
path.resolve(FIXTURES_PATH, ".secret")
];

return fileFinder.match(foo).
then(allFiles => {
assertDeep(allFiles, []);
});
});

it("matches given files with custom finder", () => {
let fileFinder = new FileFinder(FIXTURES_PATH, {
filter: filename => path.basename(filename) === "index.js"
});
let foo = [
path.resolve(FIXTURES_PATH, "index.js"),
path.resolve(FIXTURES_PATH, "something.js")
];

fileFinder.match(foo).
then(allFiles => {
assertDeep(allFiles, ["index.js"]);
});
});
});