made the baseURI available on the manifest #167
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed in aiur, and removes some akward workarounds there.
FND
approved these changes
Nov 3, 2025
There was a problem hiding this comment.
This would be safe to pull into v2.2 (we can still reshuffle those commits) - but presumably that's not necessary for aiur, so why bother?
PS: I'm slightly uncomfortable with the rationale being limited to one specific (and, arguably, external) project - that sounds a little limiting while this patch is actually a sensible improvement on a conceptual level. However, that's probably just an irrelevant FNDism.
|
We decided to keep it for our 4.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed in aiur, and removes some akward workarounds there.