Adds support for toggling display_errors in php.ini #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauria
reviewed
Oct 14, 2019
|
|
||
| # display PHP errors: | ||
| if [ $DISPLAY_ERRORS ]; then | ||
| /bin/sed -i "s/display_errors\ \=\ Off/display_errors\ \=\ On/g" /etc/php/7.0/apache2/php.ini |
Owner
There was a problem hiding this comment.
This would enable display_errors even if DISPLAY_ERRORS=no. We should use exportBoolean for this instead.
fauria
requested changes
Oct 14, 2019
Owner
fauria
left a comment
fauria
left a comment
There was a problem hiding this comment.
This is a flag that should be kept disabled by default, we should make use of exportBoolean instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some nice work.
During development, I prefer to set
display_errors = Oninphp.inito enable showing PHP syntax errors. So I created a small patch that adds support for toggling it on by using environment variableDISPLAY_ERRORS. Feel free to use it.