Skip to content

Added new source to be able to install nodejs v8 instead of v4 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added new source to be able to install nodejs v8 instead of v4 #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ LABEL Description="Cutting-edge LAMP stack, based on Ubuntu 16.04 LTS. Includes
Usage="docker run -d -p [HOST WWW PORT NUMBER]:80 -p [HOST DB PORT NUMBER]:3306 -v [HOST WWW DOCUMENT ROOT]:/var/www/html -v [HOST DB DOCUMENT ROOT]:/var/lib/mysql fauria/lamp" \
Version="1.0"

RUN curl -sL https://deb.nodesource.com/setup_8.x | bash -
Copy link
Owner

@fauria fauria Jul 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this script be available in the long run?

Also, we are installing nodejs and npm on line 49 and then doing some linking below. We may need to change that to avoid having multiple instances of node.


RUN apt-get update
RUN apt-get upgrade -y

Expand Down Expand Up @@ -72,4 +74,4 @@ VOLUME /var/log/mysql
EXPOSE 80
EXPOSE 3306

CMD ["/usr/sbin/run-lamp.sh"]
CMD ["/usr/sbin/run-lamp.sh"]