Conversation
There was a problem hiding this comment.
Pull request overview
This pull request migrates the project from legacy ESLint configuration to a shared flat config format using @feedic/eslint-config. The changes include updating ESLint from v8 to v10, consolidating linting rules into a central configuration, and removing obsolete eslint-disable comments throughout the codebase.
Changes:
- Migrated from
.eslintrc.jsontoeslint.config.mjs(flat config format) - Updated ESLint from v8.57.1 to v10.0.1 and related dependencies
- Introduced
@feedic/eslint-configas the shared configuration - Removed redundant eslint-disable comments and applied automated fixes
- Updated Biome configuration with additional rules and overrides
Reviewed changes
Copilot reviewed 15 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| eslint.config.mjs | New flat config file replacing .eslintrc.json with shared config and file-specific overrides |
| .eslintrc.json | Removed legacy ESLint configuration file |
| package.json | Updated dependencies: ESLint v10, typescript-eslint v8.56, added @feedic/eslint-config and @eslint/compat |
| package-lock.json | Updated lock file reflecting all dependency changes |
| src/internal/encode-shared.ts | Refactored Map initialization to use constructor syntax instead of set() |
| src/index.ts | Removed obsolete eslint-disable comment for unicorn/no-useless-switch-case |
| src/index.spec.ts | Changed template literal to String.raw for proper escape handling |
| src/escape.ts | Refactored getCodePoint polyfill with typeof check, removed eslint-disable comment |
| src/decode-stream.spec.ts | Changed variable initialization from -1 to proper type declaration |
| src/decode-codepoint.ts | Refactored fromCodePoint polyfill with typeof check, added block-level eslint comments |
| scripts/write-encode-map.ts | Added eslint-disable comment for unicorn/no-array-sort rule |
| src/generated/.eslintrc.json | Removed - rules now in main config |
| scripts/.eslintrc.json | Removed - rules now in main config |
| escape.js, decode.js | Removed eslint-disable comments |
| escape.d.ts, decode.d.ts | Removed eslint-disable comments |
| biome.json | Updated schema version and added comprehensive overrides |
| .prettierignore | Removed entire file (maps/ directory) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.