fix: replace deleted tyler-smith/go-bip39 with fbsobreira/go-bip39#170
Merged
fbsobreira merged 2 commits intomasterfrom Dec 3, 2025
Merged
fix: replace deleted tyler-smith/go-bip39 with fbsobreira/go-bip39#170fbsobreira merged 2 commits intomasterfrom
fbsobreira merged 2 commits intomasterfrom
Conversation
The upstream repository github.com/tyler-smith/go-bip39 has been deleted. This change migrates to github.com/fbsobreira/go-bip39 v1.2.0, a maintained fork created from a cached copy of the original library. Changes: - Replace go-bip39 import in cmd/subcommands/keys.go - Replace go-bip39 import in pkg/keys/mnemonic.go - Replace go-bip39 import in pkg/mnemonic/mnemonic.go - Update go.mod and go.sum with new dependency - Update golang.org/x dependencies to latest versions
cryptoguyinza
approved these changes
Dec 3, 2025
Collaborator
cryptoguyinza
left a comment
cryptoguyinza
left a comment
There was a problem hiding this comment.
Looks good! Lets move forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The upstream repository
github.com/tyler-smith/go-bip39has been deleted and is no longer accessible. This PR migrates the dependency togithub.com/fbsobreira/go-bip39, a maintained fork created from a cached copy of the original library.Additionally, this PR fixes bugs in the pre-commit hook that were causing false positives during commits.
Fixes #169
Type of change
Ticket
N/A
How Has This Been Tested?
Manual tests (please describe below)
Verified
go mod tidyruns without errorsVerified imports resolve correctly
Tested mnemonic generation and derivation functions
Confirmed pre-commit hook works correctly with staged go.mod/go.sum files
Checklist:
Changes
tyler-smith/go-bip39tofbsobreira/go-bip39tyler-smith/go-bip39tofbsobreira/go-bip39tyler-smith/go-bip39tofbsobreira/go-bip39golang.org/x/*packages