Update Makefile to use modern iteration#42
Closed
WolfWings wants to merge 2 commits intofcambus:masterfrom
Closed
Conversation
The current Makefile uses some vendor-specific method of looping over the SIZES variable. This updates it to use normal Makefile pattern substitution design which is more universally compatible and also can be run fully in parallel. I also modified the PSF and OTF generation to integrate appropriate size filters with comments explaining why. While some other OS platforms support the 32x64 font size that is not supported by the Linux kernel as it has a hard limit on console fonts of 32x32 due to internal implementation details, see: torvalds/linux@2b09d5d
Turns out Linux Kernel 6.12 and newer w/ kbd 2.6.0 or higher CAN load the 32x64 or larger (up to 64x128) fonts. Also removing remnant error purging code that was filtering out the 'missing glyph' warnings bdf2psf was generating when I was scripting testing locally.
Owner
|
There seems to be issues with spaces vs TAB preventing this to work out of the box but even with it fixed it doesn't seem to work when I tested with both BSD Make and GNU Make. What platform did you test your changes on? |
Owner
|
I took some time to rework the Makefile with the goal of full compatibility between BSD Make and GNU Make. Thanks for raising the portability issue in the first place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current Makefile uses some vendor-specific method of looping over the SIZES variable.
This updates it to use normal Makefile pattern substitution design which is more universally compatible and also can be run fully in parallel.
I also modified the PSF and OTF generation to integrate appropriate size filters with comments explaining why.
While some other OS platforms support the 32x64 font size that is not supported by the Linux kernel as it has a hard limit on console fonts of 32x32 due to internal implementation details.