Skip to content

Conversation

@GitBluub
Copy link

Implements a GetTLSCipherSuite function in order to know the ciphersuite used by the underlying net.conn if possible. Useful in order to track usage and notice users of deprecation of cipher suites. The other solution I found was giving access to the net.Conn object. Since it is implemented here it doesn't require any changes on users of the library

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.48%. Comparing base (8ca225b) to head (d2c2f7e).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
client_handler.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
- Coverage   86.74%   86.48%   -0.26%     
==========================================
  Files          12       12              
  Lines        2369     2376       +7     
==========================================
  Hits         2055     2055              
- Misses        238      245       +7     
  Partials       76       76              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@drakkan
Copy link
Collaborator

drakkan commented Oct 22, 2025

I think this change is not required, you can implement the MainDriverExtensionTLSVerifier interface

@GitBluub GitBluub closed this Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants