chore(deps): update golangci/golangci-lint-action action to v9

[renovate]

This PR contains the following updates:

Package	Type	Update	Change
golangci/golangci-lint-action	action	major	v8.0.0 -> v9.0.0

---

Release Notes

golangci/golangci-lint-action (golangci/golangci-lint-action)

v9.0.0

Compare Source

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.88%. Comparing base (3cf627f) to head (d8bf3d2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #583   +/-   ##
=======================================
  Coverage   86.88%   86.88%           
=======================================
  Files          12       12           
  Lines        1761     1761           
=======================================
  Hits         1530     1530           
  Misses        155      155           
  Partials       76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[claude]

PR Review: Update golangci-lint-action to v9

Summary

This PR updates the golangci-lint GitHub Action from v8.0.0 to v9.0.0. While this is generally a good dependency update, there are some concerns that need to be addressed.

---

Critical Issues

1. Outdated golangci-lint Version 🔴

Location: .github/workflows/build.yml:44

The workflow specifies version: v2.4.0 for golangci-lint itself, which is extremely outdated. The latest version is in the v1.6x range (as of 2025).

Issue: Using such an old version means:

• Missing critical bug fixes and security updates
• Missing support for newer Go language features (you're using Go 1.24/1.25)
• Potentially incompatible with the v9 action
• Not benefiting from newer, more effective linters

Recommendation: Update to the latest golangci-lint version or remove the version parameter entirely to use the action's default (recommended approach):

- name: Linting
  if: matrix.lint
  uses: golangci/[email protected]
  with:
    only-new-issues: true

---

Code Quality & Best Practices ✅

1. Automated Dependency Management: Using Renovate for automated updates is excellent practice
2. Minimal Change: The PR correctly focuses on a single, atomic change
3. Version Pinning: Using exact version tags (@v9.0.0) instead of floating tags is good for reproducibility

---

Potential Compatibility Concerns

Action Compatibility

The golangci-lint-action v9 should be compatible with your setup, but the interaction between:

• Action v9
• golangci-lint v2.4.0 (if retained)
• Go 1.24/1.25
• Your extensive linter configuration (.golangci.yml)

...may cause issues. The v2.4.0 version predates many of the linters you have enabled in your configuration.

---

Testing Recommendations

Before merging:

1. Test the workflow on a branch to ensure linting still works correctly
2. Consider updating golangci-lint version in the same PR or a follow-up
3. Review any new linting errors that might appear with updated tooling

---

Security Considerations ✅

• No security concerns with this update
• Using official GitHub Actions from the golangci organization
• Version pinning prevents supply chain attacks from floating tags

---

Performance Considerations ✅

The v9 action may have performance improvements over v8, though the impact will be minimal given your configuration.

---

Verdict

⚠️ Approve with Recommendations

The action update itself is fine, but I strongly recommend addressing the outdated golangci-lint version either in this PR or immediately after. The current v2.4.0 is incompatible with modern Go development practices and your Go 1.24/1.25 usage.

Suggested Action Items:

1. Update the version: v2.4.0 line to use latest golangci-lint or remove it entirely
2. Test the updated workflow on a branch
3. Address any new linting issues that surface

---

Review generated using the project's CLAUDE.md guidelines and best practices for Go development.

[claude]

Code Review: golangci-lint-action v8 → v9 Update

Overview

This PR updates the golangci/golangci-lint-action GitHub Action from v8.0.0 to v9.0.0. This is an automated dependency update from Renovate.

Analysis

✅ Positive Aspects

1. Minimal Change: Single line update with clear scope
2. Automated Maintenance: Renovate ensures dependencies stay current
3. Configuration Compatibility: The existing .golangci.yml uses version "2" format, which should remain compatible
4. No Breaking Parameters: The workflow uses standard parameters (version, only-new-issues) that are unlikely to change

⚠️ Considerations

1. Version Specification Inconsistency (line 44)
The workflow specifies version: v2.4.0 for golangci-lint itself. This is an outdated version - current golangci-lint is at v2.x series (likely v2.6+). Consider updating this to use a more recent version or removing the version parameter to use the action's default.

2. Go Version Matrix Issue (line 29)
The matrix uses go: [ '1.25', '1.24' ] - Go 1.25 doesn't exist yet. Current stable is Go 1.23. This appears to be a forward-looking configuration but should be verified.

3. Major Version Update
As this is a major version bump (v8→v9), there could be breaking changes:

• Check if v9 requires different Node.js runtime versions
• Verify if caching behavior has changed
• Review if any parameters were deprecated or renamed

🔍 Recommendations

1. Test the Action: Let CI run to verify the v9 action works correctly with your configuration
2. Review Release Notes: Check the v9.0.0 release notes for breaking changes
3. Update golangci-lint Version: Consider updating the version: v2.4.0 parameter to a more recent version (e.g., v2.6.1) or remove it to use the action's default
4. Fix Go Versions: Update the Go version matrix to use actual released versions (e.g., ['1.23', '1.22'])

🎯 Verdict

Recommendation: ✅ LGTM with suggestions

The core change (v8→v9 update) appears safe and follows standard dependency maintenance practices. The action update itself is low-risk, though there are some adjacent configuration improvements that could be made separately.

Suggested merge strategy:

• Merge this PR once CI passes
• Create follow-up issues for the golangci-lint version update and Go version matrix corrections

---

Review conducted according to CLAUDE.md conventions - focusing on code quality, security, and best practices for this Go FTP server library.