Replace 'string_value.Length <= 0' by 'string_value.Length == 0'

SlavaRa · SlavaRa · commit 5eea6e3a045d · 2015-09-01T19:33:18.000+03:00
diff --git a/External/Plugins/ASCompletion/Completion/ASComplete.cs b/External/Plugins/ASCompletion/Completion/ASComplete.cs
@@ -144,7 +144,7 @@ static public bool OnChar(ScintillaControl Sci, int Value, bool autoHide)
                     case ' ':
                         position--;
                         string word = GetWordLeft(Sci, ref position);
-                        if (word.Length <= 0)
+                        if (word.Length == 0)
                         {
                             char c = (char)Sci.CharAt(position);
                             if (c == ':' && features.hasEcmaTyping)
diff --git a/External/Plugins/ASCompletion/Completion/ASGenerator.cs b/External/Plugins/ASCompletion/Completion/ASGenerator.cs
@@ -3405,7 +3405,7 @@ public static bool RenameMember(ScintillaControl Sci, MemberModel member, string
         private static string GetPropertyNameFor(MemberModel member)
         {
             string name = member.Name;
-            if (name.Length < 1)
+            if (name.Length == 0)
                 return null;
             Match parts = Regex.Match(name, "([^_$]*)[_$]+(.*)");
             if (parts.Success)
@@ -3422,7 +3422,7 @@ private static string GetPropertyNameFor(MemberModel member)
         /// </summary>
         private static string GetNewPropertyNameFor(MemberModel member)
         {
-            if (member.Name.Length < 1)
+            if (member.Name.Length == 0)
                 return "prop";
             if (Regex.IsMatch(member.Name, "^[A-Z].*[a-z]"))
                 return Char.ToLower(member.Name[0]) + member.Name.Substring(1);
diff --git a/External/Plugins/ASCompletion/CustomControls/StateSavingTreeView.cs b/External/Plugins/ASCompletion/CustomControls/StateSavingTreeView.cs
@@ -154,7 +154,7 @@ public void RestoreScrollState()
 
         public TreeNode FindClosestPath(string path)
         {
-            if (path == null || path.Length < 1) return null;
+            if (string.IsNullOrEmpty(path)) return null;
             Queue queue = new Queue(path.Split('\\'));
             return FindClosestPath(base.Nodes,queue);
         }
diff --git a/External/Plugins/AirProperties/Forms/AirWizard.cs b/External/Plugins/AirProperties/Forms/AirWizard.cs
@@ -1883,11 +1883,11 @@ private void ValidateFileTypes()
                 // always true;
                 fileType.DescriptionIsValid = true;
                 // set validity based on validation requirements
-                if (fileType.Name.Length <= 0) fileType.NameIsValid = false;
+                if (fileType.Name.Length == 0) fileType.NameIsValid = false;
                 else fileType.NameIsValid = true;
                 if (!Regex.IsMatch(fileType.Extension, _FileNameRegexPattern)) fileType.ExtensionIsValid = false;
                 else fileType.ExtensionIsValid = true;
-                if (fileType.ContentType.Length <= 0) fileType.ContentTypeIsValid = false;
+                if (fileType.ContentType.Length == 0) fileType.ContentTypeIsValid = false;
                 else fileType.ContentTypeIsValid = true;
                 foreach (PropertyManager.AirFileType.AirFileTypeIcon icon in fileType.Icons)
                 {
@@ -1964,7 +1964,7 @@ private void IDField_Validating(object sender, CancelEventArgs e)
 
         private void VersionField_Validating(object sender, CancelEventArgs e)
         {
-            if (VersionField.Text.Length <= 0 && PropertyManager.MajorVersion < PropertyManager.AirVersion.V25)
+            if (VersionField.Text.Length == 0 && PropertyManager.MajorVersion < PropertyManager.AirVersion.V25)
             {
                 this.ValidationErrorProvider.SetError(VersionField, String.Format(TextHelper.GetString("Validation.InvalidProperty"), VersionLabel.Text));
                 e.Cancel = true;
@@ -2164,7 +2164,7 @@ private void FileTypeNameField_Validating(object sender, CancelEventArgs e)
             {
                 FileTypeNameField.Text = FileTypeNameField.Text.Trim();
                 selectedFileType.Name = FileTypeNameField.Text;
-                if (FileTypeNameField.Text.Length <= 0)
+                if (FileTypeNameField.Text.Length == 0)
                 {
                     selectedFileType.NameIsValid = false;
                     this.ValidationErrorProvider.SetError(FileTypeNameField, String.Format(TextHelper.GetString("Validation.InvalidProperty"), FTNameLabel.Text));
@@ -2220,7 +2220,7 @@ private void FileTypeContentTypeField_Validating(object sender, CancelEventArgs
                 FileTypeContentTypeField.Text = FileTypeContentTypeField.Text.Trim();
                 selectedFileType.ContentType = FileTypeContentTypeField.Text;
                 // validate as required field for AIR 1.5+
-                if (FileTypeContentTypeField.Text.Length <= 0 && PropertyManager.MajorVersion >= PropertyManager.AirVersion.V15)
+                if (FileTypeContentTypeField.Text.Length == 0 && PropertyManager.MajorVersion >= PropertyManager.AirVersion.V15)
                 {
                     selectedFileType.ContentTypeIsValid = false;
                     this.ValidationErrorProvider.SetError(FileTypeContentTypeField, String.Format(TextHelper.GetString("Validation.InvalidProperty"), FTContentTypeLabel.Text));
diff --git a/External/Plugins/FlashDebugger/Debugger/ExpressionContext.cs b/External/Plugins/FlashDebugger/Debugger/ExpressionContext.cs
@@ -273,7 +273,7 @@ public ExpressionContext(Session session)
         
         internal virtual void  pushName(String name)
         {
-            if (m_nameLocked || name.Length < 1) return;
+            if (m_nameLocked || name.Length == 0) return;
             m_namedPath.Add(name);
         }
 
diff --git a/External/Plugins/ProjectManager/Actions/BuildActions.cs b/External/Plugins/ProjectManager/Actions/BuildActions.cs
@@ -114,7 +114,7 @@ public bool Build(Project project, bool runOutput, bool releaseMode)
                     return false;
                 }
 
-                if (project.OutputPath.Length < 1)
+                if (project.OutputPath.Length == 0)
                 {
                     String info = TextHelper.GetString("Info.SpecifyValidOutputSWF");
                     ErrorManager.ShowInfo(info);
diff --git a/External/Plugins/ProjectManager/Controls/AS2/AS2PropertiesDialog.cs b/External/Plugins/ProjectManager/Controls/AS2/AS2PropertiesDialog.cs
@@ -93,7 +93,7 @@ private void inputBrowseButton_Click(object sender, System.EventArgs e)
 
         protected override bool Apply()
         {
-            if (injectionCheckBox.Checked && inputSwfBox.Text.Length < 1)
+            if (injectionCheckBox.Checked && inputSwfBox.Text.Length == 0)
             {
                 string msg = TextHelper.GetString("Info.SpecifyInputSwfForInjection");
                 ErrorManager.ShowInfo(msg);
diff --git a/External/Plugins/ProjectManager/Helpers/TreeViews/StateSavingTreeView.cs b/External/Plugins/ProjectManager/Helpers/TreeViews/StateSavingTreeView.cs
@@ -124,7 +124,7 @@ public void RestoreScrollState()
 
         private TreeNode FindClosestPath(string path)
         {
-            if (path == null || path.Length < 1) return null;
+            if (string.IsNullOrEmpty(path)) return null;
             Queue queue = new Queue(path.Split('\\'));
             return FindClosestPath(base.Nodes,queue);
         }
diff --git a/FlashDevelop/Dialogs/FRInDocDialog.cs b/FlashDevelop/Dialogs/FRInDocDialog.cs
@@ -695,7 +695,7 @@ private List<SearchMatch> GetResults(ScintillaControl sci)
         private bool IsValidPattern()
         {
             String pattern = this.findComboBox.Text;
-            if (pattern.Length < 1) return false;
+            if (pattern.Length == 0) return false;
             if (this.useRegexCheckBox.Checked)
             {
                 try
diff --git a/FlashDevelop/Dialogs/FRInFilesDialog.cs b/FlashDevelop/Dialogs/FRInFilesDialog.cs
@@ -994,7 +994,7 @@ private Boolean IsFileHidden(String file, IProject project)
         private Boolean IsValidPattern()
         {
             String pattern = this.findComboBox.Text;
-            if (pattern.Length < 1) return false;
+            if (pattern.Length == 0) return false;
             if (this.regexCheckBox.Checked)
             {
                 try
diff --git a/PluginCore/BBCode/BBCodeStyle.cs b/PluginCore/BBCode/BBCodeStyle.cs
@@ -48,7 +48,7 @@ public static BBCodeStyle fuseStyles(BBCodeStyle child, BBCodeStyle parent)
                 }
             }
 
-            if (outStyle.fontName == null || outStyle.fontName.Length < 1)
+            if (string.IsNullOrEmpty(outStyle.fontName))
                 outStyle.fontName = parent.fontName;
 
             if (outStyle.backColor == null)
@@ -211,7 +211,7 @@ public static float MixChannel(float back, float fore, Mode mode)
 
             public static Mode ResolveColorMode(String modeStr)
             {
-                if (modeStr == null || modeStr.Length < 1)
+                if (string.IsNullOrEmpty(modeStr))
                     return Mode.NORMAL;
 
                 _InitStatics();
diff --git a/PluginCore/BBCode/BBCodeTagHandler.cs b/PluginCore/BBCode/BBCodeTagHandler.cs
@@ -54,7 +54,7 @@ public Boolean isHandleable(IPairTagMatch tagMatch)
                 return false;
 
             _tmName = _tm.tagName;
-            if (_tmName == null || _tmName.Length < 1)
+            if (string.IsNullOrEmpty(_tmName))
                 return false;
 
             _tmName = _tmName.ToUpper();
@@ -130,7 +130,7 @@ protected Boolean _hadleTag_Font(BBCodeTagMatch tm)
             if (tmpSymbol == "\"" || tmpSymbol == "'")
                 fontName = fontName.Substring(0, fontName.Length - 1);
 
-            tm.bbCodeStyle.fontName = (fontName.Length < 1) ? null : fontName;
+            tm.bbCodeStyle.fontName = fontName.Length == 0 ? null : fontName;
             return true;
         }
 
@@ -176,7 +176,7 @@ protected Boolean _hadleTag_BgColor(BBCodeTagMatch tm)
 
         protected BBCodeStyle.Color _extractTagColor(String tagColorParam)
         {
-            if (tagColorParam == null || tagColorParam.Length < 1 || tagColorParam.Substring(0, 1) != "#")
+            if (string.IsNullOrEmpty(tagColorParam) || tagColorParam.Substring(0, 1) != "#")
                 return null;
 
             String p = tagColorParam.Substring(1);
diff --git a/PluginCore/BBCode/BBCodeTagMatcher.cs b/PluginCore/BBCode/BBCodeTagMatcher.cs
@@ -46,7 +46,7 @@ public IPairTagMatch searchOpenerAs(IPairTagMatch opener)
         public IPairTagMatch searchOpenerAs(IPairTagMatch opener, uint startAt)
         {
             BBCodeTagMatch tm = opener as BBCodeTagMatch;
-            if (tm == null || tm.tagName == null || tm.tagName.Length < 1)
+            if (tm == null || string.IsNullOrEmpty(tm.tagName))
                 return null;
 
             return searchOpenerByName(tm.tagName, startAt);
@@ -58,7 +58,7 @@ public IPairTagMatch searchOpenerByName(String tagName)
         }
         public IPairTagMatch searchOpenerByName(String tagName, uint startAt)
         {
-            if (tagName == null || tagName.Length < 1)
+            if (string.IsNullOrEmpty(tagName))
                 return null;
 
             return _searchMatch(_buildReOpenerFor(tagName), true, startAt);
@@ -71,7 +71,7 @@ public IPairTagMatch searchCloserFor(IPairTagMatch opener)
         public IPairTagMatch searchCloserFor(IPairTagMatch opener, uint startAt)
         {
             BBCodeTagMatch tm = opener as BBCodeTagMatch;
-            if (tm == null || tm.tagName == null || tm.tagName.Length < 1)
+            if (tm == null || string.IsNullOrEmpty(tm.tagName))
                 return null;
 
             IPairTagMatch successMatch = null;
@@ -100,7 +100,7 @@ public IPairTagMatch searchCloserByName(String tagName, Boolean isOpener)
         }
         public IPairTagMatch searchCloserByName(String tagName, Boolean isOpener, uint startAt)
         {
-            if (tagName == null || tagName.Length < 1)
+            if (string.IsNullOrEmpty(tagName))
                 return null;
 
             return _searchMatch(_buildReCloserFor(tagName), isOpener, startAt);
diff --git a/PluginCore/BBCode/BBCodeUtils.cs b/PluginCore/BBCode/BBCodeUtils.cs
@@ -16,7 +16,7 @@ public class BBCodeUtils
     {
         public static String assembleOutput(String input, IndexTree tree)
         {
-            if (input == null || input.Length < 1 || tree == null)
+            if (string.IsNullOrEmpty(input) || tree == null)
                 return null;
 
             String outStr = "";
@@ -125,7 +125,7 @@ public static void applyStyleToTextbox(BBCodeStyle style, RichTextBox tf, int se
 
         public static void applyStyleTreeToTextbox(RichTextBox tf, String input, IndexTree bbCodeTree)
         {
-            if (tf == null || bbCodeTree == null || input == null || input.Length < 1)
+            if (tf == null || bbCodeTree == null || string.IsNullOrEmpty(input))
                 return;
 
             tf.Text = "";
@@ -236,7 +236,7 @@ public static String rtfToText(String rtfText)
 
         private static String _replaceEnclosures(String input)
         {
-            if (input == null || input.Length < 1)
+            if (string.IsNullOrEmpty(input))
                 return input;
 
             String outStr = input;
diff --git a/PluginCore/BBCode/BottomUpParser.cs b/PluginCore/BBCode/BottomUpParser.cs
@@ -21,7 +21,7 @@ public IndexTree parse()
         {
             lastTree = null;
 
-            if (pairTagMatcher == null || this.input == null || this.input.Length < 1)
+            if (pairTagMatcher == null || string.IsNullOrEmpty(this.input))
                 return null;
 
             lastTree = _parse();
diff --git a/PluginCore/PluginCore/Utilities/LogicalComparer.cs b/PluginCore/PluginCore/Utilities/LogicalComparer.cs
@@ -42,9 +42,9 @@ public static int Compare(string s1, string s2, bool zeroesFirst)
             if ((s1 == null) && (s2 == null)) return 0;
             else if (s1 == null) return -1;
             else if (s2 == null) return 1;
-            if ((s1.Length <= 0) && (s2.Length <= 0)) return 0;
-            else if (s1.Length <= 0) return -1;
-            else if (s2.Length <= 0) return 1;
+            if (s1.Length == 0 && s2.Length == 0) return 0;
+            else if (s1.Length == 0) return -1;
+            else if (s2.Length == 0) return 1;
             //special case
             bool sp1 = Char.IsLetterOrDigit(s1[0]);
             bool sp2 = Char.IsLetterOrDigit(s2[0]);

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ static public bool OnChar(ScintillaControl Sci, int Value, bool autoHide)`
`144`	`144`	`case ' ':`
`145`	`145`	`position--;`
`146`	`146`	`string word = GetWordLeft(Sci, ref position);`
`147`		`- if (word.Length <= 0)`
	`147`	`+ if (word.Length == 0)`
`148`	`148`	`{`
`149`	`149`	`char c = (char)Sci.CharAt(position);`
`150`	`150`	`if (c == ':' && features.hasEcmaTyping)`
Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,7 @@ public void RestoreScrollState()`
`154`	`154`
`155`	`155`	`public TreeNode FindClosestPath(string path)`
`156`	`156`	`{`
`157`		`- if (path == null \|\| path.Length < 1) return null;`
	`157`	`+ if (string.IsNullOrEmpty(path)) return null;`
`158`	`158`	`Queue queue = new Queue(path.Split('\\'));`
`159`	`159`	`return FindClosestPath(base.Nodes,queue);`
`160`	`160`	`}`
Original file line number	Diff line number	Diff line change
`@@ -273,7 +273,7 @@ public ExpressionContext(Session session)`
`273`	`273`
`274`	`274`	`internal virtual void pushName(String name)`
`275`	`275`	`{`
`276`		`- if (m_nameLocked \|\| name.Length < 1) return;`
	`276`	`+ if (m_nameLocked \|\| name.Length == 0) return;`
`277`	`277`	`m_namedPath.Add(name);`
`278`	`278`	`}`
`279`	`279`
Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ public bool Build(Project project, bool runOutput, bool releaseMode)`
`114`	`114`	`return false;`
`115`	`115`	`}`
`116`	`116`
`117`		`- if (project.OutputPath.Length < 1)`
	`117`	`+ if (project.OutputPath.Length == 0)`
`118`	`118`	`{`
`119`	`119`	`String info = TextHelper.GetString("Info.SpecifyValidOutputSWF");`
`120`	`120`	`ErrorManager.ShowInfo(info);`
Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ private void inputBrowseButton_Click(object sender, System.EventArgs e)`
`93`	`93`
`94`	`94`	`protected override bool Apply()`
`95`	`95`	`{`
`96`		`- if (injectionCheckBox.Checked && inputSwfBox.Text.Length < 1)`
	`96`	`+ if (injectionCheckBox.Checked && inputSwfBox.Text.Length == 0)`
`97`	`97`	`{`
`98`	`98`	`string msg = TextHelper.GetString("Info.SpecifyInputSwfForInjection");`
`99`	`99`	`ErrorManager.ShowInfo(msg);`
Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ public void RestoreScrollState()`
`124`	`124`
`125`	`125`	`private TreeNode FindClosestPath(string path)`
`126`	`126`	`{`
`127`		`- if (path == null \|\| path.Length < 1) return null;`
	`127`	`+ if (string.IsNullOrEmpty(path)) return null;`
`128`	`128`	`Queue queue = new Queue(path.Split('\\'));`
`129`	`129`	`return FindClosestPath(base.Nodes,queue);`
`130`	`130`	`}`
Original file line number	Diff line number	Diff line change
`@@ -695,7 +695,7 @@ private List<SearchMatch> GetResults(ScintillaControl sci)`
`695`	`695`	`private bool IsValidPattern()`
`696`	`696`	`{`
`697`	`697`	`String pattern = this.findComboBox.Text;`
`698`		`- if (pattern.Length < 1) return false;`
	`698`	`+ if (pattern.Length == 0) return false;`
`699`	`699`	`if (this.useRegexCheckBox.Checked)`
`700`	`700`	`{`
`701`	`701`	`try`
Original file line number	Diff line number	Diff line change
`@@ -994,7 +994,7 @@ private Boolean IsFileHidden(String file, IProject project)`
`994`	`994`	`private Boolean IsValidPattern()`
`995`	`995`	`{`
`996`	`996`	`String pattern = this.findComboBox.Text;`
`997`		`- if (pattern.Length < 1) return false;`
	`997`	`+ if (pattern.Length == 0) return false;`
`998`	`998`	`if (this.regexCheckBox.Checked)`
`999`	`999`	`{`
`1000`	`1000`	`try`