Replace 'string_value == null || string_value.Length == 0' by 'string.isNullOrEmpty(string_value)'

Author: SlavaRa

External/Plugins/AS2Context/Context.cs

@@ -1372,7 +1372,7 @@ public override bool BuildCMD(bool failSilently)
             {
                 command = Regex.Replace(command, "[\\r\\n]\\s*\\*", "", RegexOptions.Singleline);
                 command = " " + MainForm.ProcessArgString(command) + " ";
-                if (command == null || command.Length == 0)
+                if (string.IsNullOrEmpty(command))
                 {
                     if (!failSilently)
                         throw new Exception(TextHelper.GetString("Info.InvalidQuickBuildCommand"));

External/Plugins/ASCompletion/Completion/ASComplete.cs

@@ -886,7 +886,7 @@ static public Hashtable ResolveElement(ScintillaControl Sci, string eventAction)
                 if (eventAction == "ShowDocumentation")
                 {
                     string cmd = ASContext.Context.Settings.DocumentationCommandLine;
-                    if (cmd == null || cmd.Length == 0) return null;
+                    if (string.IsNullOrEmpty(cmd)) return null;
                     // top-level vars should be searched only if the command includes member information
                     if (CurrentResolvedContext.Result.InClass == ClassModel.VoidClass && cmd.IndexOf("$(Itm") < 0) 
                         return null;
@@ -1496,7 +1496,7 @@ private static bool ResolveFunction(ScintillaControl Sci, int position, bool aut
 
             // get expression at cursor position
             ASExpr expr = GetExpression(Sci, position, true);
-            if (expr.Value == null || expr.Value.Length == 0
+            if (string.IsNullOrEmpty(expr.Value)
                 || (expr.WordBefore == "function" && expr.Separator == ' '))
                 return false;
 

External/Plugins/ASCompletion/Completion/ASGenerator.cs

@@ -2752,7 +2752,7 @@ public static void GenerateExtractMethod(ScintillaControl Sci, string NewName)
             IASContext context = ASContext.Context;
 
             string selection = Sci.SelText;
-            if (selection == null || selection.Length == 0)
+            if (string.IsNullOrEmpty(selection))
             {
                 return;
             }
@@ -4166,7 +4166,7 @@ private static void GetStartPos(string currentText, ref int startPos, string key
 
         private static string GetShortType(string type)
         {
-            if (type == null || type.Length == 0)
+            if (string.IsNullOrEmpty(type))
             {
                 return type;
             }
@@ -4186,7 +4186,7 @@ private static string FormatType(string type)
 
         private static string CleanType(string type)
         {
-            if (type == null || type.Length == 0)
+            if (string.IsNullOrEmpty(type))
             {
                 return type;
             }
@@ -4214,7 +4214,7 @@ private static string GetSuperCall(MemberModel member, List<string> typesUsed, C
                     addTypeOnce(typesUsed, getQualifiedType(param.Type, aType));
                 }
 
-            bool noRet = member.Type == null || member.Type.Length == 0 || member.Type.Equals("void", StringComparison.OrdinalIgnoreCase);
+            bool noRet = string.IsNullOrEmpty(member.Type) || member.Type.Equals("void", StringComparison.OrdinalIgnoreCase);
             if (!noRet) addTypeOnce(typesUsed, getQualifiedType(member.Type, aType));
 
             string action = "";
@@ -4257,7 +4257,7 @@ private static int AddImportsByName(List<string> typesUsed, int atLine)
             foreach (string type in typesUsed)
             {
                 cleanType = CleanType(type);
-                if (cleanType == null || cleanType.Length == 0 || cleanType.IndexOf('.') <= 0 || addedTypes.Contains(cleanType))
+                if (string.IsNullOrEmpty(cleanType) || cleanType.IndexOf('.') <= 0 || addedTypes.Contains(cleanType))
                     continue;
                 addedTypes.Add(cleanType);
                 MemberModel import = new MemberModel(cleanType.Substring(cleanType.LastIndexOf('.') + 1), cleanType, FlagType.Import, Visibility.Public);

External/Plugins/ASCompletion/Model/ASFileParser.cs

@@ -201,7 +201,7 @@ private static string getRandomStringRepl()
         /// </summary>
         private static MemberModel extractTypedCallbackModel(string comment)
         {
-            if (comment == null || comment.Length == 0)
+            if (string.IsNullOrEmpty(comment))
                 return null;
 
             int idxBraceOp = comment.IndexOf("(");

External/Plugins/ASCompletion/Model/MemberModel.cs

@@ -224,7 +224,7 @@ static public string FormatType(string type)
         }
         static public string FormatType(string type, bool allowBBCode)
         {
-            if (type == null || type.Length == 0)
+            if (string.IsNullOrEmpty(type))
                 return null;
             int p = type.IndexOf('@');
             if (p > 0)

External/Plugins/CodeRefactor/Commands/SurroundWithCommand.cs

@@ -35,7 +35,7 @@ protected void ExecutionImplementation()
                 IASContext context = ASContext.Context;
 
                 string selection = sci.SelText;
-                if (selection == null || selection.Length == 0)
+                if (string.IsNullOrEmpty(selection))
                 {
                     return;
                 }

External/Plugins/FileExplorer/PluginUI.cs

@@ -717,7 +717,7 @@ private void FileViewAfterLabelEdit(Object sender, System.Windows.Forms.LabelEdi
             ListViewItem item = null;
             try
             {
-                if (e.CancelEdit || (e.Label == null) || (e.Label.Length == 0) || (e.Label == this.previousItemLabel))
+                if (e.CancelEdit || string.IsNullOrEmpty(e.Label) || e.Label == this.previousItemLabel)
                 {
                     e.CancelEdit = true;
                     return;

External/Plugins/HaXeContext/Context.cs

@@ -1584,7 +1584,7 @@ public override bool BuildCMD(bool failSilently)
             {
                 command = Regex.Replace(command, "[\\r\\n]\\s*\\*", "", RegexOptions.Singleline);
                 command = " " + MainForm.ProcessArgString(command) + " ";
-                if (command == null || command.Length == 0)
+                if (string.IsNullOrEmpty(command))
                 {
                     if (!failSilently)
                         throw new Exception(TextHelper.GetString("Info.InvalidQuickBuildCommand"));

External/Plugins/ProjectManager/Projects/AS3/FlexProjectReader.cs

@@ -301,7 +301,7 @@ private void ReadBuildTargets()
 
         public static String ResolvePath(String path, String relativeTo)
         {
-            if (path == null || path.Length == 0) return null;
+            if (string.IsNullOrEmpty(path)) return null;
             Boolean isPathNetworked = path.StartsWith("\\\\") || path.StartsWith("//");
             if (Path.IsPathRooted(path) || isPathNetworked) return path;
             String resolvedPath = Path.Combine(relativeTo, path);

FlashDevelop/Managers/ImageManager.cs

@@ -94,7 +94,7 @@ private static void ProcessImageData(String data)
         {
             X = Y = 0;
             Icon = Bullet = -1;
-            if (data == null || data.Length == 0) return;
+            if (string.IsNullOrEmpty(data)) return;
             String[] par = data.Split('|');
             if (par.Length > 0)
             {