Skip to content

Conversation

@Shizoqua
Copy link

@Shizoqua Shizoqua commented Jan 1, 2026

Summary

This PR removes direct print() usage from Feast’s materialization flow and replaces it with standard library logging. This avoids writing to stdout from library code while still surfacing materialization progress and warnings via configured log handlers.

Changes

  • Replace print() calls in FeatureStore.materialize, materialize_incremental, and ODFV materialization helper logic with logger.info/logger.warning.
  • Remove unused colorama import (Fore, Style) after eliminating colored stdout output.

Testing

  • python -m compileall sdk/python/feast/feature_store.py

@Shizoqua Shizoqua requested a review from a team as a code owner January 1, 2026 13:16
@Shizoqua
Copy link
Author

Shizoqua commented Jan 1, 2026

@franciscojavierarceo Good day
What am I to do next?

@Shizoqua
Copy link
Author

Shizoqua commented Jan 3, 2026

@franciscojavierarceo

Good day, my PR was approved 2 days ago but I haven't had any response since then.

@ntkathole
Copy link
Member

ntkathole commented Jan 5, 2026

@Shizoqua There are unit tests failing for this change. Also, I think this changes the default cli console output for feast materialize or materialize-incremental commands. Since default cli logging configured as warning, there is no console output for these commands after this change.

@Shizoqua
Copy link
Author

Shizoqua commented Jan 5, 2026

Hi @ntkathole ! thanks for the catch.
I have updated it as requested.

Shizoqua and others added 2 commits January 5, 2026 10:45
Signed-off-by: Lanre Shittu <[email protected]>
@Shizoqua Shizoqua force-pushed the fix/materialization-use-logger branch from ee9e526 to 007c26c Compare January 5, 2026 10:45
@franciscojavierarceo
Copy link
Member

@ntkathole that's true it does change the default output. That's probably the right thing actually. We need to make sure we set

import logging
# This sets the root logger level to INFO
logging.basicConfig(level=logging.INFO)

@Shizoqua can you ensure this?

This is actually probably much better as we can add logging.debug more intentionally in the code. At the moment we dump a lot of info.

@Shizoqua
Copy link
Author

Shizoqua commented Jan 7, 2026

This is actually probably much better as we can add logging.debug more intentionally in the code. At the moment we dump a lot of info.

I will start working on it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants