-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: Use logging instead of print during materialization #5805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: Use logging instead of print during materialization #5805
Conversation
|
@franciscojavierarceo Good day |
|
Good day, my PR was approved 2 days ago but I haven't had any response since then. |
|
@Shizoqua There are unit tests failing for this change. Also, I think this changes the default cli console output for |
|
Hi @ntkathole ! thanks for the catch. |
Signed-off-by: Shizoqua <[email protected]> Signed-off-by: Lanre Shittu <[email protected]>
Signed-off-by: Lanre Shittu <[email protected]>
ee9e526 to
007c26c
Compare
|
@ntkathole that's true it does change the default output. That's probably the right thing actually. We need to make sure we set @Shizoqua can you ensure this? This is actually probably much better as we can add |
I will start working on it now |
Summary
This PR removes direct
print()usage from Feast’s materialization flow and replaces it with standard library logging. This avoids writing to stdout from library code while still surfacing materialization progress and warnings via configured log handlers.Changes
print()calls in FeatureStore.materialize, materialize_incremental, and ODFV materialization helper logic withlogger.info/logger.warning.coloramaimport (Fore,Style) after eliminating colored stdout output.Testing
python -m compileall sdk/python/feast/feature_store.py