fix: Add hybrid online store to ONLINE_STORE_CLASS_FOR_TYPE mapping #5810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the import error when using HybridOnlineStore with the shorthand type configuration in feature_store.yaml. Changes: - Add missing __init__.py to hybrid_online_store package - Add "hybrid" entry to ONLINE_STORE_CLASS_FOR_TYPE in repo_config.py - Update HybridOnlineStoreConfig type Literal to use standard "hybrid" shorthand - Update documentation to use type: hybrid Signed-off-by: yassinnouh21 <[email protected]>
franciscojavierarceo
approved these changes
Jan 4, 2026
YassinNouh21
force-pushed
the
fix/hybrid-online-store-import-5630
branch
3 times, most recently
from
f41ab82 to
fc6b866
Compare
The data source types test validates that Python ONLINE_STORE_CLASS_FOR_TYPE matches the Go operator's ValidOnlineStoreDBStorePersistenceTypes. This adds the hybrid type to both v1 and v1alpha1 API versions. Signed-off-by: yassinnouh21 <[email protected]>
YassinNouh21
force-pushed
the
fix/hybrid-online-store-import-5630
branch
from
fc6b866 to
c6a858c
Compare
Contributor
Author
|
@franciscojavierarceo ALL done we are good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes the import error when using
HybridOnlineStorewith the shorthand type configuration infeature_store.yaml.The Problem:
When users configure the HybridOnlineStore using
type: hybrid_online_store.HybridOnlineStore(as shown in the documentation), they get the error:Root Causes:
__init__.pyin thehybrid_online_storepackage directory"hybrid"shorthand entry inONLINE_STORE_CLASS_FOR_TYPEmapping (unlike all other online stores likeredis,bigtable,cassandra, etc.)HybridOnlineStoreConfig.typeused non-standard Literal values instead of the shorthand patternChanges:
__init__.pytohybrid_online_storepackage"hybrid"entry toONLINE_STORE_CLASS_FOR_TYPEinrepo_config.pyHybridOnlineStoreConfig.typeLiteral to use standard"hybrid"shorthandtype: hybridAfter this fix, users can configure:
Which issue(s) this PR fixes:
Fixes #5630
Misc
make lint-python,make format-python, pytest)type: hybridshorthand