Skip to content

chore: Run duckdb offline store tests seperately#6041

Merged
tokoko merged 6 commits intofeast-dev:masterfrom
tokoko:split-duckdb-tests
Mar 2, 2026
Merged

chore: Run duckdb offline store tests seperately#6041
tokoko merged 6 commits intofeast-dev:masterfrom
tokoko:split-duckdb-tests

Conversation

@tokoko
Copy link
Collaborator

@tokoko tokoko commented Mar 1, 2026

What this PR does / why we need it:

  • Runs duckdb offline store tests in a separate workflow, full integration suite is really hard to run. we can pull other tests into backend-specific workflows as well to simplify local runs/debugging.
  • relies on on pixi env defined inside pyproject.toml rather than our custom patched-together lockfiles.

Open with Devin

@tokoko tokoko requested a review from a team as a code owner March 1, 2026 13:16
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 6 additional findings.

Open in Devin Review

create_pushable_feature_view,
)
from tests.integration.feature_repos.universal.online_store.bigtable import (
BigtableOnlineStoreCreator,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove these?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved them down to lazily import only when actually used. this way I would have to pull in extra dependencies just for pytest collection stage.

tokoko added 6 commits March 2, 2026 13:20
Signed-off-by: tokoko <togurgenidze@gmail.com>
Signed-off-by: tokoko <togurgenidze@gmail.com>
Signed-off-by: tokoko <togurgenidze@gmail.com>
Signed-off-by: tokoko <togurgenidze@gmail.com>
Signed-off-by: tokoko <togurgenidze@gmail.com>
Signed-off-by: tokoko <togurgenidze@gmail.com>
@ntkathole ntkathole force-pushed the split-duckdb-tests branch from b321bc2 to b251fe2 Compare March 2, 2026 07:50
@tokoko tokoko merged commit 1dffd18 into feast-dev:master Mar 2, 2026
19 of 26 checks passed
@tokoko tokoko deleted the split-duckdb-tests branch March 2, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants