Merge pull request #65 from marsimeau/fix-default-state-reactivity

Fix default state reactivity

Author: marshallswain

src/auth-module/mutations.js

@@ -27,20 +27,20 @@ export default function makeAuthMutations (feathers) {
       state.errorOnAuthenticate = Object.assign({}, error)
     },
     clearAuthenticateError (state) {
-      state.errorOnAuthenticate = undefined
+      state.errorOnAuthenticate = null
     },
     setLogoutError (state, error) {
       state.errorOnLogout = Object.assign({}, error)
     },
     clearLogoutError (state) {
-      state.errorOnLogout = undefined
+      state.errorOnLogout = null
     },
 
     logout (state) {
-      state.payload = undefined
-      state.accessToken = undefined
+      state.payload = null
+      state.accessToken = null
       if (state.user) {
-        state.user = undefined
+        state.user = null
       }
     }
   }

src/auth-module/state.js

@@ -1,17 +1,18 @@
 export default function setupAuthState ({ userService }) {
   const state = {
-    accessToken: undefined, // The JWT
-    payload: undefined, // The JWT payload
+    accessToken: null, // The JWT
+    payload: null, // The JWT payload
 
     isAuthenticatePending: false,
     isLogoutPending: false,
 
-    errorOnAuthenticate: undefined,
-    errorOnLogout: undefined
+    errorOnAuthenticate: null,
+    errorOnLogout: null,
+    user: null
   }
   // If a userService string was passed, add a user attribute
   if (userService) {
-    Object.assign(state, { userService, user: undefined })
+    Object.assign(state, { userService })
   }
   return state
 }

src/service-module/mutations.js

@@ -60,8 +60,8 @@ export default function makeServiceMutations (servicePath) {
       state.keyedById = keyedById
 
       if (currentId === idToBeRemoved) {
-        state.currentId = undefined
-        state.copy = undefined
+        state.currentId = null
+        state.copy = null
       }
     },
 
@@ -100,15 +100,15 @@ export default function makeServiceMutations (servicePath) {
       state.keyedById = keyedById
 
       if (currentId && mapOfIdsToRemove[currentId]) {
-        state.currentId = undefined
-        state.copy = undefined
+        state.currentId = null
+        state.copy = null
       }
     },
 
     clearAll (state) {
       state.ids = []
-      state.currentId = undefined
-      state.copy = undefined
+      state.currentId = null
+      state.copy = null
       state.keyedById = {}
     },
 
@@ -143,8 +143,8 @@ export default function makeServiceMutations (servicePath) {
     },
 
     clearCurrent (state) {
-      state.currentId = undefined
-      state.copy = undefined
+      state.currentId = null
+      state.copy = null
     },
 
     // Deep assigns current to copy
@@ -211,37 +211,37 @@ export default function makeServiceMutations (servicePath) {
       state.errorOnFind = Object.assign({}, serializeError(payload))
     },
     clearFindError (state) {
-      state.errorOnFind = undefined
+      state.errorOnFind = null
     },
     setGetError (state, payload) {
       state.errorOnGet = Object.assign({}, serializeError(payload))
     },
     clearGetError (state) {
-      state.errorOnGet = undefined
+      state.errorOnGet = null
     },
     setCreateError (state, payload) {
       state.errorOnCreate = Object.assign({}, serializeError(payload))
     },
     clearCreateError (state) {
-      state.errorOnCreate = undefined
+      state.errorOnCreate = null
     },
     setUpdateError (state, payload) {
       state.errorOnUpdate = Object.assign({}, serializeError(payload))
     },
     clearUpdateError (state) {
-      state.errorOnUpdate = undefined
+      state.errorOnUpdate = null
     },
     setPatchError (state, payload) {
       state.errorOnPatch = Object.assign({}, serializeError(payload))
     },
     clearPatchError (state) {
-      state.errorOnPatch = undefined
+      state.errorOnPatch = null
     },
     setRemoveError (state, payload) {
       state.errorOnRemove = Object.assign({}, serializeError(payload))
     },
     clearRemoveError (state) {
-      state.errorOnRemove = undefined
+      state.errorOnRemove = null
     }
   }
 }

src/service-module/state.js

@@ -2,8 +2,8 @@ export default function makeDefaultState (servicePath, { idField, autoRemove, pa
   const state = {
     ids: [],
     keyedById: {},
-    currentId: undefined,
-    copy: undefined,
+    currentId: null,
+    copy: null,
     idField,
     servicePath,
     autoRemove,
@@ -16,12 +16,12 @@ export default function makeDefaultState (servicePath, { idField, autoRemove, pa
     isPatchPending: false,
     isRemovePending: false,
 
-    errorOnFind: undefined,
-    errorOnGet: undefined,
-    errorOnCreate: undefined,
-    errorOnUpdate: undefined,
-    errorOnPatch: undefined,
-    errorOnRemove: undefined
+    errorOnFind: null,
+    errorOnGet: null,
+    errorOnCreate: null,
+    errorOnUpdate: null,
+    errorOnPatch: null,
+    errorOnRemove: null
   }
   return state
 }

test/auth-module/actions.test.js

@@ -23,19 +23,19 @@ describe('Auth Module - Actions', () => {
     const authState = store.state.auth
     const actions = mapActions('auth', ['authenticate'])
 
-    assert(authState.accessToken === undefined)
-    assert(authState.errorOnAuthenticate === undefined)
-    assert(authState.errorOnLogout === undefined)
+    assert(authState.accessToken === null)
+    assert(authState.errorOnAuthenticate === null)
+    assert(authState.errorOnLogout === null)
     assert(authState.isAuthenticatePending === false)
     assert(authState.isLogoutPending === false)
-    assert(authState.payload === undefined)
+    assert(authState.payload === null)
 
     const request = {strategy: 'local', email: 'test', password: 'test'}
     actions.authenticate.call({$store: store}, request)
     .then(response => {
       assert(authState.accessToken === response.accessToken)
-      assert(authState.errorOnAuthenticate === undefined)
-      assert(authState.errorOnLogout === undefined)
+      assert(authState.errorOnAuthenticate === null)
+      assert(authState.errorOnLogout === null)
       assert(authState.isAuthenticatePending === false)
       assert(authState.isLogoutPending === false)
       let expectedPayload = {
@@ -47,12 +47,12 @@ describe('Auth Module - Actions', () => {
     })
 
     // Make sure proper state changes occurred before response
-    assert(authState.accessToken === undefined)
-    assert(authState.errorOnAuthenticate === undefined)
-    assert(authState.errorOnLogout === undefined)
+    assert(authState.accessToken === null)
+    assert(authState.errorOnAuthenticate === null)
+    assert(authState.errorOnLogout === null)
     assert(authState.isAuthenticatePending === true)
     assert(authState.isLogoutPending === false)
-    assert(authState.payload === undefined)
+    assert(authState.payload === null)
   })
 
   it('Logout', (done) => {
@@ -73,12 +73,12 @@ describe('Auth Module - Actions', () => {
     .then(authResponse => {
       actions.logout.call({$store: store})
       .then(response => {
-        assert(authState.accessToken === undefined)
-        assert(authState.errorOnAuthenticate === undefined)
-        assert(authState.errorOnLogout === undefined)
+        assert(authState.accessToken === null)
+        assert(authState.errorOnAuthenticate === null)
+        assert(authState.errorOnLogout === null)
         assert(authState.isAuthenticatePending === false)
         assert(authState.isLogoutPending === false)
-        assert(authState.payload === undefined)
+        assert(authState.payload === null)
         done()
       })
     })
@@ -101,7 +101,7 @@ describe('Auth Module - Actions', () => {
     const authState = store.state.auth
     const actions = mapActions('auth', ['authenticate'])
 
-    assert(authState.user === undefined)
+    assert(authState.user === null)
 
     const request = {strategy: 'local', email: 'test', password: 'test'}
     actions.authenticate.call({$store: store}, request)

test/auth-module/auth-module.test.js

@@ -15,12 +15,13 @@ describe('Auth Module', () => {
       })
       const authState = store.state.auth
       const expectedAuthState = {
-        accessToken: undefined,
-        errorOnAuthenticate: undefined,
-        errorOnLogout: undefined,
+        accessToken: null,
+        errorOnAuthenticate: null,
+        errorOnLogout: null,
         isAuthenticatePending: false,
         isLogoutPending: false,
-        payload: undefined
+        payload: null,
+        user: null
       }
 
       assert.deepEqual(authState, expectedAuthState, 'has the default state')

test/auth.test.js

@@ -88,7 +88,7 @@ describe('feathers-vuex:auth - Reducer', () => {
       isPending: false,
       isError: false,
       isSignedIn: false,
-      accessToken: undefined,
+      accessToken: null,
       error: undefined
     }
     const newState = reducer(state, {})
@@ -108,7 +108,7 @@ describe('feathers-vuex:auth - Reducer', () => {
       isPending: true,
       isError: false,
       isSignedIn: false,
-      accessToken: undefined,
+      accessToken: null,
       error: undefined
     }
     const newState = reducer(state, action)
@@ -144,7 +144,7 @@ describe('feathers-vuex:auth - Reducer', () => {
       isPending: false,
       isError: true,
       isSignedIn: false,
-      accessToken: undefined,
+      accessToken: null,
       error
     }
     const newState = reducer(state, action)
@@ -160,7 +160,7 @@ describe('feathers-vuex:auth - Reducer', () => {
       isPending: false,
       isError: false,
       isSignedIn: false,
-      accessToken: undefined,
+      accessToken: null,
       error: undefined
     }
     const newState = reducer(state, action)