Merge pull request #566 from DaniGTA/patch-1

marshallswain · web-flow · commit 9601217a2cbd · 2021-03-06T13:18:05.000-07:00
FIX Can't call update when id is 0
diff --git a/src/service-module/make-base-model.ts b/src/service-module/make-base-model.ts
@@ -421,7 +421,7 @@ export default function makeBaseModel(options: FeathersVuexOptions) {
       const { idField, _dispatch } = this.constructor as typeof BaseModel
       const id = getId(this, idField)
 
-      if (!id) {
+      if (id !== 0 && !id) {
         const error = new Error(
           `Missing ${idField} property. You must create the data before you can update with this data`
         )

Original file line number	Diff line number	Diff line change
`@@ -421,7 +421,7 @@ export default function makeBaseModel(options: FeathersVuexOptions) {`
`421`	`421`	`const { idField, _dispatch } = this.constructor as typeof BaseModel`
`422`	`422`	`const id = getId(this, idField)`
`423`	`423`
`424`		`- if (!id) {`
	`424`	`+ if (id !== 0 && !id) {`
`425`	`425`	`const error = new Error(`
`426`	`426`	`Missing ${idField} property. You must create the data before you can update with this data`
`427`	`427`	`)`