Skip to content
This repository was archived by the owner on Nov 2, 2025. It is now read-only.

Added secrets store#16

Open
ahlag wants to merge 15 commits intomainfrom
feature/secrets-object
Open

Added secrets store#16
ahlag wants to merge 15 commits intomainfrom
feature/secrets-object

Conversation

@ahlag
Copy link
Collaborator

@ahlag ahlag commented Mar 4, 2023

Description

Added secrets as environment variables for Feathr that can be managed on Azure Key Vault
Resolves #9

How was this PR tested?

Run the following command

helm install <Release Name> ./feathr-online-aks-integration \
    --set pipelineConf=$(cat <absolute path>/pipeline.conf | base64) \
    --set lookup=$(cat <absolute path>/lookup.json | base64) \
    --set userAssignedIdentityID=<User Assigned Identity ID> \
    --set tenantId=<Tenant ID>

User Assigned ID

az aks show -g <resource-group> -n <cluster-name> --query addonProfiles.azureKeyvaultSecretsProvider.identity.clientId -o tsv

To access your key vault, you can use the user-assigned managed identity that you created when you enabled a managed identity on your AKS cluster

Tenant ID
screen_shot 2023-04-08 at 0 14 03

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

@ahlag ahlag self-assigned this Mar 4, 2023
@ahlag ahlag added the enhancement New feature or request label Mar 4, 2023
@ahlag
Copy link
Collaborator Author

ahlag commented Mar 16, 2023

@blrchen
Could you please check if this architecture is ok?
k8s-key-vault drawio (1)

@ahlag ahlag requested a review from blrchen April 7, 2023 11:57
@ahlag ahlag changed the title [WIP] Added secrets store Added secrets store Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding secret support for Feathr Online

1 participant