[New Transformer] ChiMergeDiscretisor#459

Open

Morgan-Sell wants to merge 22 commits intofeature-engine:mainfrom

Morgan-Sell:chi_merge_disc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[New Transformer] ChiMergeDiscretisor#459

[New Transformer] ChiMergeDiscretisor#459
Morgan-Sell wants to merge 22 commits intofeature-engine:mainfrom
Morgan-Sell:chi_merge_disc

Commits on May 22, 2022

initial commit. create class skeleton.

expand fit and transform

start _create_contingency_table. stuck. debating if neccessary

Commits on Jun 4, 2022

create _calc_chi_square()

create _calc_chi_square()

revise _create_contingency_table(). simplify code

Commits on Jun 13, 2022

create test_chi_merge_discretiser.py

Commits on Jun 14, 2022

create/pass test_create_contingency_table() and fix syntax errors

fix errors

Commits on Jun 18, 2022

chi_merge_disc

change _create_contingency_table() to _create_frequency_matrix(). method now returns a 2-d numpy array and 1-d numpy array instead of a dictionary.

change _create_contingency_table() to _create_frequency_matrix(). method now returns a 2-d numpy array and 1-d numpy array instead of a dictionary.

delete _create_chi_square_scores_dict(). create _perform_chi_merge(). New method is incomplete. Issue with some of the chi-square calculations. It only happens w/ certain distributions

Commits on Jun 19, 2022

update init()

update _perform_chi_merge()

create test_chi_merge(). need to fix error. know test does not pass. the first 2 and last 2 chi-square values do not match expected results. meanwhile, the other 9 chi-square values match. unsure w…

update _perform_chi_merge()

Commits on Jun 28, 2022

add/revise comments

fix nomanclature

edit test_chi_merge()

Commits on Jun 29, 2022

expand test_chi_merge(). test still fails.

ran isort and expand docstring

Uh oh!

[New Transformer] ChiMergeDiscretisor#459Morgan-Sell wants to merge 22 commits intofeature-engine:mainfeature-engine/feature_engine:mainfrom Morgan-Sell:chi_merge_discMorgan-Sell/feature_engine:chi_merge_discCopy head branch name to clipboard

Commits

Commits on May 22, 2022

Commits on Jun 4, 2022

Commits on Jun 13, 2022

Commits on Jun 14, 2022

Commits on Jun 18, 2022

Commits on Jun 19, 2022

Commits on Jun 28, 2022

Commits on Jun 29, 2022

[New Transformer] ChiMergeDiscretisor#459
Morgan-Sell wants to merge 22 commits intofeature-engine:mainfrom
Morgan-Sell:chi_merge_disc