Add translation for overview page to Uzbek language#799
Add translation for overview page to Uzbek language#799illright merged 3 commits intofeature-sliced:masterfrom
Conversation
|
I don't have experience in contributing; this is my first contribution to an open-source project. So if I make any mistakes while creating a PR or committing, I would appreciate your feedback. However, I did my best with the translation. Thanks! |
illright
left a comment
illright
left a comment
There was a problem hiding this comment.
Thank you so much! I've looked at the translation as best as I could and it looks good to me. Just one small thing and then we can merge this
| - `📁 pages` | ||
| - `📁 shared` | ||
|
|
||
| These top-level folders are called _layers_. Let's look deeper: |
There was a problem hiding this comment.
Looks like there are some original English lines left, could you remove them please? Here and also below
There was a problem hiding this comment.
Thank you for review and i'm fix this. Sorry for that
There was a problem hiding this comment.
No problem, but there are more of those, I see you only removed one. Could you go through the rest of the file and remove the English lines from other places?
There was a problem hiding this comment.
I made a few changes, but I didn't translate certain concepts because doing so could distort the meaning of the sentence. I did my best, and I would really appreciate it if, in the review, you could point out exactly where the mistakes are next time. Thank you!
illright
left a comment
illright
left a comment
There was a problem hiding this comment.
Thank you for making the changes! It's good to merge now :)
|
@illright Hi, I only contributed a translation and didn't modify any code, but the CI/CD pipeline failed. Could you clarify why this happened? Also, my translation hasn't appeared on the production docs page yet. Should I wait for deployment, or is there anything else I need to do? Thanks! |
|
Yeah, don't worry about the pipeline, it's failing for unrelated reasons. It's also why your translation hasn't appeared yet — I will fix the pipeline and redeploy and then let you know! |
|
@rajaboff-dev Okay, this has been resolved, your translation has been deployed :) Note: we unfortunately lost control of the feature-sliced.design domain, so for now you can see the page here: https://feature-sliced.github.io/documentation/uz/docs/get-started/overview |
thanks for all :) |
2 participants
Background
This PR adds the Uzbek language translation for the overview page. I'm a new contributor, and I'm still learning, so there might be some mistakes in my changes. Please feel free to point them out!
There is no related issue for this change.
Changelog