docs: standardize English terminology in with-react-query documentation#802
Merged
illright merged 1 commit intofeature-sliced:masterfrom Jun 19, 2025
Merged
docs: standardize English terminology in with-react-query documentation#802illright merged 1 commit intofeature-sliced:masterfrom
illright merged 1 commit intofeature-sliced:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes English terminology in the Korean localization of the with-react-query guide by reverting translated React Query and FSD terms back to their original English for clarity and consistency.
- Reverted Korean translations of React Query concepts (query, mutation, pagination, etc.) to English.
- Unified Feature-Sliced Design folder and API naming in English.
- Updated headings, comments, and link texts to use consistent English terms.
Comments suppressed due to low confidence (4)
i18n/kr/docusaurus-plugin-content-docs/current/guides/tech/with-react-query.mdx:8
- [nitpick] Consider wrapping directory names like
entitiesin backticks (e.g.,entities별로) to clearly distinguish code/folder names from regular text.
### 해결책 — entities별로 분리하기
i18n/kr/docusaurus-plugin-content-docs/current/guides/tech/with-react-query.mdx:10
- [nitpick] For consistency, wrap both
entitiesandentityin backticks to indicate code/folder names, and ensure singular/plural usage matches the actual directory structure.
프로젝트가 이미 entities 단위로 구성되어 있으며, 각 요청이 단일 entity에 해당한다면, entities별로 코드를 분리하는 것이 좋습니다. 예를 들어, 다음과 같은 디렉토리 구조를 사용할 수 있습니다:
i18n/kr/docusaurus-plugin-content-docs/current/guides/tech/with-react-query.mdx:118
- [nitpick] To maintain style consistency, consider formatting
Requestas code (Request조직화) or translating to Korean (요청 조직화) to avoid mixing languages in headings.
## Request 조직화
i18n/kr/docusaurus-plugin-content-docs/current/guides/tech/with-react-query.mdx:229
- [nitpick] Consider wrapping
segmentsin backticks or capitalizing it consistently (e.g.,api segmentsorAPI Segments) to match code formatting elsewhere.
getPosts 함수는 `api` segments의 `get-posts.ts` 파일에서 정의됩니다.
i18n/kr/docusaurus-plugin-content-docs/current/guides/tech/with-react-query.mdx
Show resolved
Hide resolved
illright
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Reverted React Query terminology from Korean to original English to prevent meaning distortion and maintain technical accuracy. English terms provide better clarity and consistency with official documentation.