Implement delete_many

Author: febus982

sqlalchemy_bind_manager/_repository/async_.py

@@ -97,6 +97,11 @@ async def delete(self, instance: MODEL) -> None:
         async with self._get_session() as session:
             await session.delete(instance)
 
+    async def delete_many(self, instances: Iterable[MODEL]) -> None:
+        async with self._get_session() as session:
+            for instance in instances:
+                await session.delete(instance)
+
     async def find(
         self,
         search_params: Union[None, Mapping[str, Any]] = None,

sqlalchemy_bind_manager/_repository/sync.py

@@ -86,6 +86,11 @@ def delete(self, instance: MODEL) -> None:
         with self._get_session() as session:
             session.delete(instance)
 
+    def delete_many(self, instances: Iterable[MODEL]) -> None:
+        with self._get_session() as session:
+            for model in instances:
+                session.delete(model)
+
     def find(
         self,
         search_params: Union[None, Mapping[str, Any]] = None,

sqlalchemy_bind_manager/protocols.py

@@ -62,7 +62,14 @@ async def get_many(self, identifiers: Iterable[PRIMARY_KEY]) -> List[MODEL]:
     async def delete(self, instance: MODEL) -> None:
         """Deletes a model.
 
-        :param instance: The model instance or the primary key
+        :param instance: The model instance
+        """
+        ...
+
+    async def delete_many(self, instances: Iterable[MODEL]) -> None:
+        """Deletes a collection of models in a single transaction.
+
+        :param instances: The model instances
         """
         ...
 
@@ -211,7 +218,14 @@ def get_many(self, identifiers: Iterable[PRIMARY_KEY]) -> List[MODEL]:
     def delete(self, instance: MODEL) -> None:
         """Deletes a model.
 
-        :param instance: The model instance or the primary key
+        :param instance: The model instance
+        """
+        ...
+
+    async def delete_many(self, instances: Iterable[MODEL]) -> None:
+        """Deletes a collection of models in a single transaction.
+
+        :param instances: The model instances
         """
         ...
 

tests/repository/async_/test_delete.py

@@ -35,6 +35,14 @@ async def test_delete_inexistent_raises_exception(
     with pytest.raises(Exception):
         await repo.delete(4)
 
+    with pytest.raises(Exception):
+        await repo.delete(
+            model_class(
+                model_id=823,
+                name="Someone",
+            )
+        )
+
 
 async def test_relationships_are_respected(
     related_repository_class, related_model_classes, sa_manager
@@ -55,5 +63,8 @@ async def test_relationships_are_respected(
     await repo.delete(retrieved_parent)
 
     async with repo._get_session() as session:
-        result = [x for x in (await session.execute(select(related_model_classes[1]))).scalars()]
+        result = [
+            x
+            for x in (await session.execute(select(related_model_classes[1]))).scalars()
+        ]
         assert len(result) == 0

tests/repository/async_/test_delete_many.py

@@ -0,0 +1,72 @@
+import pytest
+from sqlalchemy import select
+
+
+async def test_can_delete_by_instance(repository_class, model_class, sa_manager):
+    model = model_class(
+        model_id=1,
+        name="Someone",
+    )
+    model2 = model_class(
+        model_id=2,
+        name="SomeoneElse",
+    )
+    repo = repository_class(sa_manager.get_bind())
+    await repo.save_many({model, model2})
+
+    results = [x for x in await repo.find()]
+    assert len(results) == 2
+
+    await repo.delete_many([model])
+    results = [x for x in await repo.find()]
+    assert len(results) == 1
+    assert results[0].model_id == 2
+    assert results[0].name == "SomeoneElse"
+
+
+async def test_delete_inexistent_raises_exception(
+    repository_class, model_class, sa_manager
+):
+    repo = repository_class(sa_manager.get_bind())
+
+    results = [x for x in await repo.find()]
+    assert len(results) == 0
+
+    with pytest.raises(Exception):
+        await repo.delete_many([4])
+
+    with pytest.raises(Exception):
+        await repo.delete_many(
+            [
+                model_class(
+                    model_id=823,
+                    name="Someone",
+                )
+            ]
+        )
+
+
+async def test_relationships_are_respected(
+    related_repository_class, related_model_classes, sa_manager
+):
+    parent = related_model_classes[0](
+        name="A Parent",
+    )
+    child = related_model_classes[1](name="A Child")
+    child2 = related_model_classes[1](name="Another Child")
+    parent.children.append(child)
+    parent.children.append(child2)
+    repo = related_repository_class(sa_manager.get_bind())
+    await repo.save(parent)
+
+    retrieved_parent = await repo.get(parent.parent_model_id)
+    assert len(retrieved_parent.children) == 2
+
+    await repo.delete_many([retrieved_parent])
+
+    async with repo._get_session() as session:
+        result = [
+            x
+            for x in (await session.execute(select(related_model_classes[1]))).scalars()
+        ]
+        assert len(result) == 0

tests/repository/sync/test_delete.py

@@ -1,5 +1,4 @@
 import pytest
-
 from sqlalchemy import select
 
 
@@ -34,6 +33,14 @@ def test_delete_inexistent_raises_exception(repository_class, model_class, sa_ma
     with pytest.raises(Exception):
         repo.delete(4)
 
+    with pytest.raises(Exception):
+        repo.delete(
+            model_class(
+                model_id=823,
+                name="Someone",
+            )
+        )
+
 
 def test_relationships_are_respected(
     related_repository_class, related_model_classes, sa_manager
@@ -54,5 +61,7 @@ def test_relationships_are_respected(
     repo.delete(retrieved_parent)
 
     with repo._get_session() as session:
-        result = [x for x in session.execute(select(related_model_classes[1])).scalars()]
+        result = [
+            x for x in session.execute(select(related_model_classes[1])).scalars()
+        ]
         assert len(result) == 0

tests/repository/sync/test_delete_many.py

@@ -0,0 +1,69 @@
+import pytest
+from sqlalchemy import select
+
+
+def test_can_delete_by_instance(repository_class, model_class, sa_manager):
+    model = model_class(
+        model_id=1,
+        name="Someone",
+    )
+    model2 = model_class(
+        model_id=2,
+        name="SomeoneElse",
+    )
+    repo = repository_class(sa_manager.get_bind())
+    repo.save_many({model, model2})
+
+    results = [x for x in repo.find()]
+    assert len(results) == 2
+
+    repo.delete_many([model])
+    results = [x for x in repo.find()]
+    assert len(results) == 1
+    assert results[0].model_id == 2
+    assert results[0].name == "SomeoneElse"
+
+
+def test_delete_inexistent_raises_exception(repository_class, model_class, sa_manager):
+    repo = repository_class(sa_manager.get_bind())
+
+    results = [x for x in repo.find()]
+    assert len(results) == 0
+
+    with pytest.raises(Exception):
+        repo.delete_many([4])
+
+    with pytest.raises(Exception):
+        repo.delete_many(
+            [
+                model_class(
+                    model_id=823,
+                    name="Someone",
+                )
+            ]
+        )
+
+
+def test_relationships_are_respected(
+    related_repository_class, related_model_classes, sa_manager
+):
+    parent = related_model_classes[0](
+        name="A Parent",
+    )
+    child = related_model_classes[1](name="A Child")
+    child2 = related_model_classes[1](name="Another Child")
+    parent.children.append(child)
+    parent.children.append(child2)
+    repo = related_repository_class(sa_manager.get_bind())
+    repo.save(parent)
+
+    retrieved_parent = repo.get(parent.parent_model_id)
+    assert len(retrieved_parent.children) == 2
+
+    repo.delete_many([retrieved_parent])
+
+    with repo._get_session() as session:
+        result = [
+            x for x in session.execute(select(related_model_classes[1])).scalars()
+        ]
+        assert len(result) == 0