Fix plugin for android latest and add var in strings.xml#461
Open
djodjonx wants to merge 2 commits intofechanique:masterfrom
Open
Fix plugin for android latest and add var in strings.xml#461djodjonx wants to merge 2 commits intofechanique:masterfrom
djodjonx wants to merge 2 commits intofechanique:masterfrom
Conversation
|
+1 |
|
Great job! |
|
I am using your branch with the latest version of cordova android, it works great! It's a shame this library seems unmantained lately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have fix pluflin issue with the path of file strings in android latest, check the path for old and new android platform.
I have changed the regex for replace android app-id and api-key who's not add in file, the regex replace an item who's not exist. Now, all balises are create.