Skip to content

Comments

Upgrade garminconnect to v0.2.34#8

Open
federicopellegatta wants to merge 3 commits intomasterfrom
feature/upgrade-garminconnect
Open

Upgrade garminconnect to v0.2.34#8
federicopellegatta wants to merge 3 commits intomasterfrom
feature/upgrade-garminconnect

Conversation

@federicopellegatta
Copy link
Owner

@federicopellegatta federicopellegatta commented Nov 17, 2025

This PR updates project dependencies to their latest versions, with a particular focus on the garminconnect library. Additionally, it removes deprecated methods from GarminClient that are now part of the upstream Garmin class in the new library version.

Changes

  • Upgraded garminconnect from v0.2.30 to v0.2.34.
  • Removed the following methods from GarminClient, because they are now implemented in the upstream Garmin class (which GarminClient extends);
    def get_training_plan_by_id(self, training_plan_id: int) -> dict[str, Any]:
        """Returns training plan by id"""
        url = f"/trainingplan-service/trainingplan/phased/{training_plan_id}"
        return self.connectapi(url)
    
    def get_scheduled_workout_by_id(self, scheduled_workout_id: int) -> dict[str, Any]:
        """Returns scheduled workout by id"""
        url = f"/workout-service/schedule/{scheduled_workout_id}"
        return self.connectapi(url)
  • Updated any other outdated dependencies to their latest compatible versions.

Tests

  • Existing unit and integration tests verified to pass with updated dependencies.
  • Confirmed that removed methods are available via the Garmin base class where needed.

@federicopellegatta federicopellegatta self-assigned this Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant