feat: parameter from cont to page and add newer link for pagination#105
Merged
dahlia merged 4 commits intofedify-dev:mainfrom Feb 9, 2025
Merged
feat: parameter from cont to page and add newer link for pagination#105dahlia merged 4 commits intofedify-dev:mainfrom
cont to page and add newer link for pagination#105dahlia merged 4 commits intofedify-dev:mainfrom
Conversation
yamanoku
commented
Feb 8, 2025
src/pages/profile/index.tsx
Outdated
Comment on lines
53
to
62
| const totalPosts = await db.query.posts.findMany({ | ||
| where: and( | ||
| eq(posts.accountId, owner.id), | ||
| or(eq(posts.visibility, "public"), eq(posts.visibility, "unlisted")), | ||
| ), | ||
| }); | ||
| const maxPage = Math.ceil(totalPosts.length / PAGE_SIZE); | ||
| if (page > maxPage) { | ||
| return c.notFound(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Error that occurs when ?page exceeds the total number of pages.
dahlia
requested changes
Feb 8, 2025
Member
dahlia
left a comment
dahlia
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I left a few review comments, so please take a look!
src/pages/profile/index.tsx
Outdated
Comment on lines
53
to
62
| const totalPosts = await db.query.posts.findMany({ | ||
| where: and( | ||
| eq(posts.accountId, owner.id), | ||
| or(eq(posts.visibility, "public"), eq(posts.visibility, "unlisted")), | ||
| ), | ||
| }); | ||
| const maxPage = Math.ceil(totalPosts.length / PAGE_SIZE); | ||
| if (page > maxPage) { | ||
| return c.notFound(); | ||
| } |
dahlia
approved these changes
Feb 9, 2025
Member
dahlia
left a comment
dahlia
left a comment
There was a problem hiding this comment.
Everything looks good now! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #104