refactor(twisted/consumer): update asyncio.iscoroutinefunction to inspect.iscoroutine#558
Open
servusdei2018 wants to merge 5 commits intofedora-infra:developfrom
Open
refactor(twisted/consumer): update asyncio.iscoroutinefunction to inspect.iscoroutine#558servusdei2018 wants to merge 5 commits intofedora-infra:developfrom
servusdei2018 wants to merge 5 commits intofedora-infra:developfrom
Conversation
servusdei2018
force-pushed
the
develop
branch
from
5c84226 to
95555f7
Compare
…pect.iscoroutine Signed-off-by: Nate Bracy <nate@bracy.dev>
Signed-off-by: Nate Bracy <nate@bracy.dev>
servusdei2018
force-pushed
the
develop
branch
from
7b8b563 to
5053de5
Compare
Contributor
|
This would also need to change the comment block that states a specific reason for using asyncio. over inspect. And we should verify that we don't need this to work on Python < 3.10, which isn't a safe assumption - RHEL 9's system Python is 3.9, so if we run anything that uses fedora-messaging on EL 9, it could potentially be an issue. |
…n 3.9- Signed-off-by: Nate <37554478+servusdei2018@users.noreply.github.com>
servusdei2018
force-pushed
the
develop
branch
from
ea8cdcd to
d55eb1c
Compare
Author
@AdamWill Just added backwards compatibility for Python pre-3.10. |
Signed-off-by: Nate Bracy <nate@bracy.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #546
asyncio.iscoroutinefunctionis deprecated as of Python 3.14 (stable) and will be removed in Python 3.16.This PR changes those deprecated references to use
inspect.iscoroutinefunction, added in Python 3.5.