Add limit and offset parameters to get_assertions_by_badge#265
Open
Daniel-1600 wants to merge 1 commit intofedora-infra:developfrom
Open
Add limit and offset parameters to get_assertions_by_badge#265Daniel-1600 wants to merge 1 commit intofedora-infra:developfrom
Daniel-1600 wants to merge 1 commit intofedora-infra:developfrom
Conversation
sdglitched
suggested changes
Apr 4, 2026
Contributor
sdglitched
left a comment
sdglitched
left a comment
There was a problem hiding this comment.
Thank you for working on this.
Please make the requested changes, along with signing the commit and following the 50-character rule for commit messages.
Also, specify the AI usage as per ACP and explain what your thought process was during the development as per the latest decision.
| return self.session.query(Assertion).filter_by(person_id=person.id).all() | ||
|
|
||
| def get_assertions_by_badge(self, badge_id): | ||
| def get_assertions_by_badge(self, badge_id, limit=None, offset=None): |
Contributor
There was a problem hiding this comment.
Please maintain consistency across the codebase.
Suggested change
| def get_assertions_by_badge(self, badge_id, limit=None, offset=None): | |
| def get_assertions_by_badge(self, badge_id: str, begin: int, limit: int): |
| return ( | ||
| self.session.query(Assertion) | ||
| .filter(func.lower(Assertion.badge_id) == func.lower(badge_id)) | ||
| .order_by(Assertion.issued_on) |
Contributor
There was a problem hiding this comment.
Having the oldest assertion first is not very helpful. Use a similar sorting to that used in
tahrir-api/tahrir_api/dbapi.py
Line 875 in 43e1906
Suggested change
| .order_by(Assertion.issued_on) | |
| .order_by(Assertion.issued_on.desc()) |
| self.session.query(Assertion) | ||
| .filter(func.lower(Assertion.badge_id) == func.lower(badge_id)) | ||
| .order_by(Assertion.issued_on) | ||
| .offset(offset) |
Contributor
There was a problem hiding this comment.
Suggested change
| .offset(offset) | |
| .offset(begin) |
Comment on lines
896
to
901
| """ | ||
| Get all assertions of a particular badge. | ||
|
|
||
| :type badge_id: str | ||
| :param badge_id: Badge id to get assertions for. | ||
| """ |
Contributor
There was a problem hiding this comment.
Add the new parameters in the docstring.
Comment on lines
+680
to
+708
| @pytest.fixture | ||
| def multiple_assertions(api, dummy_badge_id): | ||
| """Add multiple assertions for the same badge to test pagination.""" | ||
| emails = [f"user{i}@tester.com" for i in range(5)] | ||
| for email in emails: | ||
| api.add_person(email) | ||
| api.add_assertion(dummy_badge_id, email, None, f"link_{email}") | ||
| return emails | ||
|
|
||
|
|
||
| def test_get_assertions_by_badge_limit(api, dummy_badge_id, multiple_assertions): | ||
| result = api.get_assertions_by_badge(dummy_badge_id, limit=3) | ||
| assert len(result) == 3 | ||
|
|
||
|
|
||
| def test_get_assertions_by_badge_offset(api, dummy_badge_id, multiple_assertions): | ||
| all_results = api.get_assertions_by_badge(dummy_badge_id) | ||
| offset_results = api.get_assertions_by_badge(dummy_badge_id, offset=2) | ||
| assert len(offset_results) == len(all_results) - 2 | ||
|
|
||
|
|
||
| def test_get_assertions_by_badge_limit_and_offset(api, dummy_badge_id, multiple_assertions): | ||
| result = api.get_assertions_by_badge(dummy_badge_id, limit=2, offset=1) | ||
| assert len(result) == 2 | ||
|
|
||
|
|
||
| def test_get_assertions_by_badge_no_limit_no_offset(api, dummy_badge_id, multiple_assertions): | ||
| result = api.get_assertions_by_badge(dummy_badge_id) | ||
| assert len(result) == 5 |
Contributor
There was a problem hiding this comment.
Add test cases in a new commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #264