Skip to content

Implement pagination on the search page for users and badges from endpoints#854

Open
olamidepeterojo wants to merge 1 commit intofedora-infra:swatantryafrom
olamidepeterojo:search_page
Open

Implement pagination on the search page for users and badges from endpoints#854
olamidepeterojo wants to merge 1 commit intofedora-infra:swatantryafrom
olamidepeterojo:search_page

Conversation

@olamidepeterojo
Copy link
Copy Markdown

Implement pagination on the search page for users and badges from endpoints

image --- Screenshot 2026-03-25 123216

Fixes #741

@gridhead gridhead self-requested a review March 31, 2026 03:11
@gridhead gridhead self-assigned this Mar 31, 2026
@gridhead gridhead added Bug cle Community Linux Engineering labels Mar 31, 2026
Copy link
Copy Markdown
Member

@gridhead gridhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the design language of the already implemented pagination areas.

Image

Notice the arrow buttons at the bottom left side of the page on the accolade path.

@olamidepeterojo
Copy link
Copy Markdown
Author

Yes i do, currently on it

@olamidepeterojo
Copy link
Copy Markdown
Author

Hello @gridhead, I have done as instructed with an image attached below.
Secondly, I know ive been running tox -e docs before pushing commits and that reformats the code base but before pushing this commit I made sure not to run the command before pushing but I see 17 files changed which I find surprising because my previous commit had 1 change if im not mistaken. Kindly understand it was not in my intention to do so with the hopes of duplicate work to increase the likelihood of my selection

image

@gridhead
Copy link
Copy Markdown
Member

gridhead commented Apr 2, 2026

@olamidepeterojo, you do realise that tox -e docs does not format the codebase but instead runs Sphinx to build the project's documentation from the docs/ directory, right? You would not have felt the need to run the tox -e docs commands or anything similar if you had gone through the workflow files or the testing configuration. The same learning would have helped you understand that maybe it is the tox -e format that you perhaps might have ended up running on the entire thing that resulted in changes across 17 files in total.

See, I understand that it is not your intention to be spammy across your pull requests, but it cannot be helped if you appear as one with your actual work. I have stated countless times that when we are reviewing your pull requests, we expect them to be in a ready state. It does not have to be polished or even functional, but it should give us an idea of how you approach a problem statement. From the representation that I get from your changes after my suggestions, it does not paint quite a favourable picture for you, if I were to be honest with you.

@olamidepeterojo
Copy link
Copy Markdown
Author

@olamidepeterojo, you do realise that tox -e docs does not format the codebase but instead runs Sphinx to build the project's documentation from the docs/ directory, right? You would not have felt the need to run the tox -e docs commands or anything similar if you had gone through the workflow files or the testing configuration. The same learning would have helped you understand that maybe it is the tox -e format that you perhaps might have ended up running on the entire thing that resulted in changes across 17 files in total.

See, I understand that it is not your intention to be spammy across your pull requests, but it cannot be helped if you appear as one with your actual work. I have stated countless times that when we are reviewing your pull requests, we expect them to be in a ready state. It does not have to be polished or even functional, but it should give us an idea of how you approach a problem statement. From the representation that I get from your changes after my suggestions, it does not paint quite a favourable picture for you, if I were to be honest with you.

You’re right @gridhead , I misunderstood the purpose of the tox environments and ended up running formatting across the repository instead of limiting it to my changes. I have made sure to correct this

@olamidepeterojo olamidepeterojo force-pushed the search_page branch 2 times, most recently from f7bb319 to a06c44f Compare April 2, 2026 07:34
users and badges from endpoints.

Assisted-by: ChatGPT.

Signed-off-by: Olamide Ojo
 <peterojoolamide@gmail.com>
Signed-off-by: Olamide Ojo <peterojoolamide@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug cle Community Linux Engineering

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement pagination on the search page for users and badges from endpoints

2 participants