Skip to content

Implement the necessary endpoints for performing CRUD operations on the ISSUERS relation#855

Merged
gridhead merged 1 commit intofedora-infra:swatantryafrom
olamidepeterojo:issuers
Apr 3, 2026
Merged

Implement the necessary endpoints for performing CRUD operations on the ISSUERS relation#855
gridhead merged 1 commit intofedora-infra:swatantryafrom
olamidepeterojo:issuers

Conversation

@olamidepeterojo
Copy link
Copy Markdown

Fixes #695

@gridhead gridhead self-assigned this Mar 31, 2026
@gridhead gridhead self-requested a review March 31, 2026 03:21
@gridhead gridhead added enhancement cle Community Linux Engineering स्वातंत्र्य Fedora Badges Revamp Project labels Mar 31, 2026
Copy link
Copy Markdown
Member

@gridhead gridhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the following requested changes.

Copy link
Copy Markdown
Member

@gridhead gridhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checks still break.

Copy link
Copy Markdown
Contributor

@sdglitched sdglitched left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olamidepeterojo, thank you for working on this.

Please make the suggested changes and reword the commit message to something like Add REST API endpoint for listing Issuers.

If you want to give a further description in the commit message, use another -m flag for it.

Also, please let me know what your thought process was while working on this Pull Request.

@olamidepeterojo
Copy link
Copy Markdown
Author

@olamidepeterojo, thank you for working on this.

Please make the suggested changes and reword the commit message to something like Add REST API endpoint for listing Issuers.

If you want to give a further description in the commit message, use another -m flag for it.

Also, please let me know what your thought process was while working on this Pull Request.

Hello @sdglitched,

Would make changes to the commit message as instructed.

I started by reviewing the existing implementations in tahrir/endpoints/admin/users.py and badges.py to understand the expected structure for the admin endpoints.

I went on to search the tahrirdb and found out it supported the create, fetch and delete endpoints. Then I implemented the issuer endpoints by following the same structure used for users and badges.

Copy link
Copy Markdown
Member

@gridhead gridhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🌮

Signed-off-by: Olamide Ojo <peterojoolamide@gmail.com>
Copy link
Copy Markdown
Member

@gridhead gridhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one nitpick that I decided to correct by myself without having to wait on another round of reviews because all the change that have been made so far seems to show some semblance of promise from your end. It finally looks like all of our tough comments have made a positive impact on your approach towards not only the Fedora Badges Revamp Project but towards the software development discipline, in general. All I am going to ask of you, from here on out, is to step up your contributions and to proactively reach out for feedback and support from friends and mentors rather than overly relying on AI tooling. That, and please ensure that your commit activities are signed on the same line as your name and not on a separate line, because that is a trivial issue that I had to spend some time fixing.

@gridhead gridhead merged commit 9dbe67f into fedora-infra:swatantrya Apr 3, 2026
2 checks passed
@olamidepeterojo
Copy link
Copy Markdown
Author

I had one nitpick that I decided to correct by myself without having to wait on another round of reviews because all the change that have been made so far seems to show some semblance of promise from your end. It finally looks like all of our tough comments have made a positive impact on your approach towards not only the Fedora Badges Revamp Project but towards the software development discipline, in general. All I am going to ask of you, from here on out, is to step up your contributions and to proactively reach out for feedback and support from friends and mentors rather than overly relying on AI tooling. That, and please ensure that your commit activities are signed on the same line as your name and not on a separate line, because that is a trivial issue that I had to spend some time fixing.

Okay I have noted all you said, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cle Community Linux Engineering enhancement स्वातंत्र्य Fedora Badges Revamp Project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement the necessary endpoints for performing CURD operations on the ISSUERS relation

3 participants