Implement the necessary endpoints for performing CRUD operations on the ISSUERS relation#855
Conversation
gridhead
left a comment
There was a problem hiding this comment.
Please make the following requested changes.
55ff61a to
aab8145
Compare
sdglitched
left a comment
There was a problem hiding this comment.
@olamidepeterojo, thank you for working on this.
Please make the suggested changes and reword the commit message to something like Add REST API endpoint for listing Issuers.
If you want to give a further description in the commit message, use another -m flag for it.
Also, please let me know what your thought process was while working on this Pull Request.
Hello @sdglitched, Would make changes to the commit message as instructed. I started by reviewing the existing implementations in I went on to search the |
Signed-off-by: Olamide Ojo <peterojoolamide@gmail.com>
gridhead
left a comment
There was a problem hiding this comment.
I had one nitpick that I decided to correct by myself without having to wait on another round of reviews because all the change that have been made so far seems to show some semblance of promise from your end. It finally looks like all of our tough comments have made a positive impact on your approach towards not only the Fedora Badges Revamp Project but towards the software development discipline, in general. All I am going to ask of you, from here on out, is to step up your contributions and to proactively reach out for feedback and support from friends and mentors rather than overly relying on AI tooling. That, and please ensure that your commit activities are signed on the same line as your name and not on a separate line, because that is a trivial issue that I had to spend some time fixing.
Okay I have noted all you said, thank you! |
Fixes #695