Add Towncrier-based changelog system with GitHub release integration#870
Add Towncrier-based changelog system with GitHub release integration#870olamidepeterojo wants to merge 1 commit intofedora-infra:swatantryafrom
Conversation
Signed-off-by: Olamide Ojo <peterojoolamide@gmail.com>
gridhead
added
docs
स्वातंत्र्य
gridhead
left a comment
gridhead
left a comment
There was a problem hiding this comment.
Please rework this pull request based on the suggested changes and review the AI-Assisted Contributions Policy to disclose the use of AI tools.
There was a problem hiding this comment.
Did you actually bother looking into the releases of the project? 1.0.0 dates back a couple of years, and it sure as heck did not come out on 21st March 2026 (i.e. its actual release date is 22nd April 2024).
There was a problem hiding this comment.
Had you spent some time with the codebase, you would have realised that there is a CHANGELOG.md file already that has been maintained since the version v0.2.0, which came out back on 13th March 2013.
There was a problem hiding this comment.
Please review the distribution portion of the workflow file before delving into creating something in a similar line by yourself. This could have allowed you to contribute to other parts in a meaningful manner.
That is, of course, not to mention the time that I could have saved efforts by avoiding reviewing this change and thus putting it into some other pull request that actually is trying to make a useful change.
| with: | ||
| body_path: CHANGELOG.md No newline at end of file |
There was a problem hiding this comment.
This would dump the entire file (which is, not to mention, already mistaken) into the most recently released version, instead of extracting parts that pertain to a specific release.
| run: towncrier build --yes --version ${{ github.ref_name }} | ||
|
|
||
| - name: Create GitHub Release | ||
| uses: softprops/action-gh-release@v1 |
There was a problem hiding this comment.
If you check this line, the existing workflow already makes use of the more recent version of the action workflow, thus giving us one more reason as to why your changes do not help us.
There was a problem hiding this comment.
These changes not only conflict with the existing changelog generation methods, but they also end up breaking them with a mistaken format and an incorrect location.
2 participants
Fixes #480