feat: Convert diff page from Jinja2 template to React component#883
Open
Marvinrose wants to merge 3 commits intofedora-infra:swatantryafrom
Open
feat: Convert diff page from Jinja2 template to React component#883Marvinrose wants to merge 3 commits intofedora-infra:swatantryafrom
Marvinrose wants to merge 3 commits intofedora-infra:swatantryafrom
Conversation
gridhead
requested changes
Apr 6, 2026
Member
gridhead
left a comment
gridhead
left a comment
There was a problem hiding this comment.
Before I start with a formal round of reviews, could you please address the following issues?
- Please sign your commit activities inside the commit messages
- Please mention your AI tooling inside the commit messages, if any
- Please limit the length of your commit messages to under 50 chars
- Please squash needless commits after you have resolved conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #882
Changes
/json/diff/<id_a>/<id_b>API endpoint intahrir/views/user.pyto expose badge diff data between two usersfrontend/src/routes/diff.jsxReact component following the project's established patterns (direct fetch, two-column layout, vibe theming)/diff/:id_a/:id_broute infrontend/src/main.jsxApproach
Following the pattern established in
addendum.jsx, the component uses directfetch()withuseState/useEffectrather than Redux RTK Query, keeping the implementation simple and consistent with the codebase style.The two-column layout matches existing routes, left sidebar shows user links and navigation, right main area shows the comparison summary and three-column badge breakdown.