Skip to content

Remove legacy Jinja2 templates#912

Open
Valkyriezz wants to merge 1 commit intofedora-infra:swatantryafrom
Valkyriezz:remove-templates
Open

Remove legacy Jinja2 templates#912
Valkyriezz wants to merge 1 commit intofedora-infra:swatantryafrom
Valkyriezz:remove-templates

Conversation

@Valkyriezz
Copy link
Copy Markdown

Summary

  • Delete all 21 Jinja2 template files from tahrir/templates/
    .html template files (index.html, user.html, badge.html, badge_full.html, leaderboard.html, explore.html, explore_badges.html, report.html, about.html, diff.html, admin.html, builder.html, thingiview.html, assertion_widget.html, tags.html, error.html, _base.html, _badge-base.html, _functions.html,test.html)
  • These templates are part of the legacy frontend being replaced by React
  • No API endpoints or React frontend code references these templates

Fixes part of #904 (Task 1)

Copy link
Copy Markdown
Member

@gridhead gridhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Valkyriezz, please also include the removal of the views that require the usage of the templates that you just happened to have removed, because the application will not initialise if it does not end up finding the templates that it expects to find at the moment. Also, please sign the commits, if you have not done that already before another round of reviews.

@gridhead gridhead self-assigned this Apr 2, 2026
@gridhead gridhead added स्वातंत्र्य Fedora Badges Revamp Project cle Community Linux Engineering labels Apr 2, 2026
@gridhead gridhead linked an issue Apr 2, 2026 that may be closed by this pull request
@Valkyriezz
Copy link
Copy Markdown
Author

Hi @gridhead, I've addressed your feedback. Along with removing the 21 Jinja2 template files, I've now also removed the 15 view functions that depended on them.
The JSON/API endpoints, RSS feeds, and redirect handlers are all preserved only the render_template() code paths were removed. Error handlers have been converted to return JSON instead of rendering templates.
Since this is a larger change touching 8 view files, I'd appreciate your review to make sure nothing was missed.

Copy link
Copy Markdown
Member

@gridhead gridhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Valkyriezz, you still do not seem to have signed your commits after having asked for it multiple times. When you do that, please also ensure to squash all your commits into one.

Assisted-by: Claude Code <noreply@anthropic.com>
Signed-off-by: Valkyriezz <vanshikhashri@gmail.com>
@Valkyriezz
Copy link
Copy Markdown
Author

I think removing the views is part of Task 2 and already has a PR, but feel free to review mine as well :) will make changes accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cle Community Linux Engineering स्वातंत्र्य Fedora Badges Revamp Project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove legacy Jinja2 frontend and associated dead code

2 participants