Use useLoadingState hook in route files#918
Open
Valkyriezz wants to merge 1 commit intofedora-infra:swatantryafrom
Open
Use useLoadingState hook in route files#918Valkyriezz wants to merge 1 commit intofedora-infra:swatantryafrom
Valkyriezz wants to merge 1 commit intofedora-infra:swatantryafrom
Conversation
afea594 to
23b3c17
Compare
Assisted-by: Claude Code
23b3c17 to
608fd18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
useLoadingStatehook infeatures/hooks.jshandles showing and hiding the loading indicator. It's already used across the CRUD files, but none of the route files were using it. Instead, each route manually repeated the sameuseEffectwithdispatch(showLoad())/dispatch(hideLoad()).This change replaces that duplicated pattern with the existing hook in 10 route files:
homepage,accolade,accolist,identity,userpast,findpage,rankings,rarities,recently, andcategory.Four routes —
callback,campaign,addendum, andgovernorwere left unchanged because their loading logic is more complex and doesn't fit the hook's pattern.Closes #917