Hydration error warning caused by nested hyperlink HTML elements.#919
Open
thedunncodes wants to merge 2 commits intofedora-infra:swatantryafrom
Open
Hydration error warning caused by nested hyperlink HTML elements.#919thedunncodes wants to merge 2 commits intofedora-infra:swatantryafrom
thedunncodes wants to merge 2 commits intofedora-infra:swatantryafrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hydration error warning pops up every time the home page is loaded, This is caused by nesting an hyperlink element e.g
<a>in another. Many reusable components in the modern packages often have different components implementing an HTML hyperlink element in them. When these components are not used properly it could result into an hydration error.In the tahrir project, this error occurs at
tahrir/frontend/src/routes/homepage.jsxwhere we have a<Link>component nested under a<VertItem>component which also contains a<Link>component.Fixes #903
Changes
The
<VertItem>component has been provisioned with anonClickoption which can be used in place of thelinkoption in this case.I created a
handleAwardsClicksfunction to satisy theonClickevent in the<VertItem>component. Within the function, navigation is properly handled by theuseNavigationhook from react router.