Skip to content

docs: add DCO sign-off instructions in Contributing guide#923

Open
Flashl3opard wants to merge 1 commit intofedora-infra:swatantryafrom
Flashl3opard:docs/signoff-guide
Open

docs: add DCO sign-off instructions in Contributing guide#923
Flashl3opard wants to merge 1 commit intofedora-infra:swatantryafrom
Flashl3opard:docs/signoff-guide

Conversation

@Flashl3opard
Copy link
Copy Markdown

Description

Adds a section explaining how to include a DCO sign-off (Signed-off-by) in commits.

Motivation

While contributing, I noticed that commit sign-off (DCO) is required but not mentioned in the contributing guidelines. This can lead to confusion and rejected pull requests for new contributors, and may also increase the review overhead for maintainers.

This change adds clear instructions to help contributors follow the expected workflow.

Changes

  • Added "Commit Sign-off (DCO)" section under Guidelines
  • Included command usage (git commit -s)
  • Added a quick way to verify sign-off

Checklist

  • Documentation update only
  • No code changes

Note: (I'm not an Outreachy Contributor ✌🏻)

Copilot AI review requested due to automatic review settings April 2, 2026 09:54
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Developer Certificate of Origin (DCO) commit sign-off guidance to the contributing documentation to reduce contributor confusion and PR rejections.

Changes:

  • Adds a “Commit Sign-off (DCO)” section describing how to create signed-off commits.
  • Updates inline code formatting in the Tests section (e.g., tox, # no-qa).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@sdglitched sdglitched left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly check the commit and make the suggested changes.

Also, for this small change only one commit should suffice. Please squash the multiple commits into a single one.

Copy link
Copy Markdown
Contributor

@sdglitched sdglitched left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Flashl3opard why are you trying to imply that you had unnecessary changes in the older commit?

As requested earlier, please squash the multiple commits into a single one and make sure the character count does not cross 50.

Signed-off-by: FlashL3opard <69573060+Flashl3opard@users.noreply.github.com>
@Flashl3opard
Copy link
Copy Markdown
Author

@sdglitched Thanks for the clarification. I’ve squashed the commits into a single commit. Let me know if anything else needs to be updated.

@Flashl3opard Flashl3opard requested a review from sdglitched April 2, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants